Uh oh!
There was an error while loading. Please reload this page.
GH-111485: Allow arbitrary annotations on instructions and micro-ops. - #111697
Conversation
… declare specializing micro-ops
gvanrossum
commented
Nov 3, 2023
Maybe we need to add a test for |
jbower-fb
commented
Nov 3, 2023
Yes, we definitely still want this please.
There were some tests, but this PR removed them. @markshannon is there some reason |
markshannon
commented
Nov 6, 2023
I'll add back the functionality. I assumed it was a feature we added for development and hadn't cleaned up. |
f4b5df7 to
140a681Comparemarkshannon
commented
Nov 6, 2023
Since it is not clear to me if and when |
jbower-fb
commented
Nov 6, 2023
Great, thank you for doing that. The motivation for |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
This allows us to be explicit about classifications of uops that are currently encoded in the code generator or analysis phase.
As an example, I've added a "specializing" annotation to denote which micro-ops specialize, rather than perform an action.
Using that we can avoid emitting the specialization code in tier 2.
A possible extension is to allow more than one annotation, but this PR only allows one for now.