Skip to content

gh-111789: Use PyDict_GetItemRef() in Objects/ - #111827

Merged
serhiy-storchaka merged 7 commits into
python:mainfrom
serhiy-storchaka:use-dict_getitemref2
Nov 14, 2023
Merged

gh-111789: Use PyDict_GetItemRef() in Objects/#111827
serhiy-storchaka merged 7 commits into
python:mainfrom
serhiy-storchaka:use-dict_getitemref2

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Nov 7, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Nov 7, 2023
Closed
@vstinner

vstinner commented Nov 8, 2023

Copy link
Copy Markdown
Member

Ping me when this PR is ready for a review. Now it's marked as a draft.

@serhiy-storchaka

serhiy-storchaka commented Nov 8, 2023

Copy link
Copy Markdown
MemberAuthor

It is ready for review. I marked is as draft because I do not insist that all these changes should be applied.

@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review November 8, 2023 17:47
serhiy-storchaka
serhiy-storchaka commented Nov 13, 2023
View reviewed changes
Comment threadObjects/object.c Outdated
Comment threadObjects/typeobject.c Outdated
vstinner
vstinner previously approved these changes Nov 13, 2023
View reviewed changes

@vstinnervstinner left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some suggestions

Comment threadObjects/object.c Outdated
Comment threadObjects/typeobject.c Outdated
Comment threadObjects/typeobject.c Outdated
Comment threadObjects/typeobject.c Outdated
@vstinner
vstinner dismissed their stale reviewNovember 13, 2023 14:16

oops, there is a bug, i should not approve the PR

@vstinner

vstinner commented Nov 13, 2023

Copy link
Copy Markdown
Member

LGTM with some suggestions

Sorry, _PyObject_GenericGetAttrWithDict() should be fixed before I can approve the PR.

serhiy-storchaka
serhiy-storchaka commented Nov 13, 2023
View reviewed changes
Comment threadObjects/object.c Outdated
Comment threadObjects/object.c Outdated
@serhiy-storchaka@vstinner
Apply suggestions from code review
2e6a25c
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
vstinner approved these changes Nov 13, 2023
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadObjects/typeobject.c Outdated
@serhiy-storchaka

serhiy-storchaka commented Nov 13, 2023

Copy link
Copy Markdown
MemberAuthor

Thank you for your review, Victor. I applied all your suggestions.

@serhiy-storchaka
serhiy-storchaka merged commit 18203a6 into python:mainNov 14, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka@aisk
pythongh-111789: Use PyDict_GetItemRef() in Objects/ (pythonGH-111827)
9c401c0
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka@Glyphack
pythongh-111789: Use PyDict_GetItemRef() in Objects/ (pythonGH-111827)
ed707d4
@serhiy-storchaka
serhiy-storchaka deleted the use-dict_getitemref2 branch July 1, 2026 16:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka@vstinner