Skip to content

gh-111863: Rename Py_NOGIL to Py_GIL_DISABLED - #111864

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:rename-Py_NOGIL
Nov 20, 2023
Merged

gh-111863: Rename Py_NOGIL to Py_GIL_DISABLED#111864
hugovk merged 1 commit into
python:mainfrom
hugovk:rename-Py_NOGIL

Conversation

@hugovk

@hugovkhugovk commented Nov 8, 2023

Copy link
Copy Markdown
Member

A suggestion for gh-111863, following the pattern of the --disable-gil flag.

cc @colesbury

@hugovkhugovk added 3.13 bugs and security fixes topic-free-threading labels Nov 8, 2023
@bedevere-appbedevere-appBot mentioned this pull request Nov 8, 2023
Closed
@hugovk
hugovk requested a review from colesburyNovember 8, 2023 18:30
@brettcannon
brettcannon removed their request for review November 8, 2023 18:56
@pitrou

pitrou commented Nov 9, 2023

Copy link
Copy Markdown
Member

Then I would suggest Py_GIL_DISABLED (using a noun + adjective, rather than a verb, for a constant).

@colesbury

colesbury commented Nov 9, 2023

Copy link
Copy Markdown
Contributor

Thanks @hugovk. I would like some comment first from the Python steering council about the preferred name so that:

  1. We don't need to change it again in the future.
  2. We don't spend too much time bikeshedding the name.

Beyond that, we'll also need to change pypa/packaging as it uses sysconfig.get_config_var("Py_NOGIL"), which comes from the macro defined in configure.

@colesburycolesbury mentioned this pull request Nov 9, 2023
Closed
@gpshead

gpshead commented Nov 19, 2023

Copy link
Copy Markdown
Member

The SC threw our xkcd-randomized dart at the dartboard of bikeshed names: it landed on Py_GIL_DISABLED.

@hugovk
hugovk removed the request for review from gvanrossumNovember 20, 2023 09:45
@hugovk

hugovk commented Nov 20, 2023

Copy link
Copy Markdown
MemberAuthor

Thanks, updated to use Py_GIL_DISABLED.

@hugovkhugovk changed the title gh-111863: Rename Py_NOGIL to Py_DISABLE_GILgh-111863: Rename Py_NOGIL to Py_GIL_DISABLEDNov 20, 2023
@hugovkhugovk mentioned this pull request Nov 20, 2023
Merged
@hugovk
hugovk merged commit 3b3ec0d into python:mainNov 20, 2023
@hugovk
hugovk deleted the rename-Py_NOGIL branch November 20, 2023 13:52
@hugovkhugovk mentioned this pull request Nov 20, 2023
Merged
scoder pushed a commit to cython/cython that referenced this pull request Nov 20, 2023
@hugovk
PEP 703: Accept newPy_GIL_DISABLEDmacro in addition toPY_NOGIL(…
fcd5a49
…GH-5852)
See python/cpython#111863
See python/cpython#111864
scoder pushed a commit to cython/cython that referenced this pull request Nov 20, 2023
@hugovk@scoder
PEP 703: Accept newPy_GIL_DISABLEDmacro in addition toPY_NOGIL(…
f258b67
…GH-5852)
See python/cpython#111863
See python/cpython#111864
@Yhg1s

Yhg1s commented Nov 21, 2023

Copy link
Copy Markdown
Member

This created a file in Misc/NEWS.d/next/C_API, presumably by accident. The actual directory should be Misc/NEWS.d/next/"C API" (a space instead of an underscore). Was the blurb file created by hand, or is this a bug in blurb or blurb-it?

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@hugovk@aisk
pythongh-111863: RenamePy_NOGILtoPy_GIL_DISABLED(python#111864)
935eef8
Rename Py_NOGIL to Py_GIL_DISABLED
ambv added a commit to python/peps that referenced this pull request Mar 6, 2024
@ambv
[pep703] Py_NOGIL is now Py_GIL_DISABLED afterpython/cpython#111864
5a1e77c
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@hugovk@Glyphack
pythongh-111863: RenamePy_NOGILtoPy_GIL_DISABLED(python#111864)
0a59da0
Rename Py_NOGIL to Py_GIL_DISABLED
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes

Assignees

No one assigned

Labels

3.13bugs and security fixestopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hugovk@pitrou@colesbury@gpshead@Yhg1s