Skip to content

gh-103791: handle BaseExceptionGroup in contextlib.suppress() - #111910

Merged
iritkatriel merged 2 commits into
python:mainfrom
Zac-HD:zac-hd/suppress-baseexceptiongroup
Nov 10, 2023
Merged

gh-103791: handle BaseExceptionGroup in contextlib.suppress()#111910
iritkatriel merged 2 commits into
python:mainfrom
Zac-HD:zac-hd/suppress-baseexceptiongroup

Conversation

@Zac-HD

@Zac-HDZac-HD commented Nov 9, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

@Zac-HD
Zac-HD requested a review from 1st1 as a code ownerNovember 9, 2023 18:51
@bedevere-appbedevere-appBot mentioned this pull request Nov 9, 2023
Closed
@Zac-HDZac-HD mentioned this pull request Nov 9, 2023
Closed
@gaogaotiantian

gaogaotiantian commented Nov 9, 2023

Copy link
Copy Markdown
Member

I don't think we are going to backport this. This is not a bug in 3.12 - it's doing what the docs says. So I believe the changeversion could be just 3.13.

@Zac-HD

Zac-HD commented Nov 9, 2023

Copy link
Copy Markdown
ContributorAuthor

IMO it should be backported to 3.12.1: it seems likely that the missing support for BaseExceptionGroup was simply an oversight (@ambv might be able to confirm?), and it's much easier on users if we patch it promptly - the .0 versions aren't widely used.

iritkatriel
iritkatriel reviewed Nov 9, 2023
View reviewed changes
Comment threadDoc/library/contextlib.rst
Comment threadLib/test/test_contextlib.py
@iritkatriel

iritkatriel commented Nov 9, 2023

Copy link
Copy Markdown
Member

IMO it should be backported to 3.12.1: it seems likely that the missing support for BaseExceptionGroup was simply an oversight (@ambv might be able to confirm?), and it's much easier on users if we patch it promptly - the .0 versions aren't widely used.

I'd call it a bug and backport.

@iritkatrieliritkatriel added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.12 only security fixes labels Nov 9, 2023
iritkatriel
iritkatriel reviewed Nov 9, 2023
View reviewed changes
Comment threadDoc/library/contextlib.rst Outdated
@Zac-HD
Zac-HDforce-pushed the zac-hd/suppress-baseexceptiongroup branch from 0dfe1a7 to bb4220cCompareNovember 10, 2023 04:40
@Zac-HD
Zac-HDforce-pushed the zac-hd/suppress-baseexceptiongroup branch from bb4220c to b8bc136CompareNovember 10, 2023 04:59
@iritkatriel
iritkatriel merged commit d61313b into python:mainNov 10, 2023
@miss-islington-app

miss-islington-appBot commented Nov 10, 2023

Copy link
Copy Markdown

Thanks @Zac-HD for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2023
@Zac-HD@miss-islington
pythongh-103791: handleBaseExceptionGroupin `contextlib.suppress(…
9e2096d
…)` (pythonGH-111910)
(cherry picked from commit d61313b)
Co-authored-by: Zac Hatfield-Dodds <zac.hatfield.dodds@gmail.com>
@bedevere-app

bedevere-appBot commented Nov 10, 2023

Copy link
Copy Markdown

GH-111955 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Nov 10, 2023
iritkatriel pushed a commit that referenced this pull request Nov 10, 2023
@miss-islington@Zac-HD
[3.12]gh-103791: handleBaseExceptionGroupin `contextlib.suppress…
3780414
…()` (GH-111910) (#111955)
gh-103791: handle `BaseExceptionGroup` in `contextlib.suppress()` (GH-111910)
(cherry picked from commit d61313b)
Co-authored-by: Zac Hatfield-Dodds <zac.hatfield.dodds@gmail.com>
@Zac-HD
Zac-HD deleted the zac-hd/suppress-baseexceptiongroup branch November 10, 2023 17:02
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@Zac-HD@aisk
pythongh-103791: handleBaseExceptionGroupin `contextlib.suppress(…
a2535e0
…)` (python#111910)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@Zac-HD@Glyphack
pythongh-103791: handleBaseExceptionGroupin `contextlib.suppress(…
27cc8c8
…)` (python#111910)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes
@1st11st1Awaiting requested review from 1st1

Assignees

No one assigned

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zac-HD@gaogaotiantian@iritkatriel