Skip to content

[3.12] gh-109181: Fix refleak in tb_get_lineno() - #111948

Merged
vstinner merged 1 commit into
python:3.12from
vstinner:tb_get_lineno
Nov 10, 2023
Merged

[3.12] gh-109181: Fix refleak in tb_get_lineno()#111948
vstinner merged 1 commit into
python:3.12from
vstinner:tb_get_lineno

Conversation

@vstinner

@vstinnervstinner commented Nov 10, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

PyFrame_GetCode() returns a strong reference.

@vstinner
pythongh-109181: Fix refleak in tb_get_lineno()
f2f63b7
PyFrame_GetCode() returns a strong reference.
@vstinnervstinner added the needs backport to 3.11 only security fixes label Nov 10, 2023
@bedevere-appbedevere-appBot mentioned this pull request Nov 10, 2023
Closed
@vstinner

vstinner commented Nov 10, 2023

Copy link
Copy Markdown
MemberAuthor

cc @pablogsal

@vstinnervstinner mentioned this pull request Nov 10, 2023
Closed
iritkatriel
iritkatriel reviewed Nov 10, 2023
View reviewed changes
Comment threadPython/traceback.c
iritkatriel
iritkatriel reviewed Nov 10, 2023
View reviewed changes
Comment threadPython/traceback.c
@vstinner
vstinner merged commit 4b0c875 into python:3.12Nov 10, 2023
@vstinner
vstinner deleted the tb_get_lineno branch November 10, 2023 13:07
@miss-islington-app

miss-islington-appBot commented Nov 10, 2023

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2023
@vstinner@miss-islington
[3.12]pythongh-109181: Fix refleak in tb_get_lineno() (pythonGH-111948)
e2631ea
PyFrame_GetCode() returns a strong reference.
(cherry picked from commit 4b0c875)
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-appBot commented Nov 10, 2023

Copy link
Copy Markdown

GH-111951 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Nov 10, 2023
@pablogsal

pablogsal commented Nov 10, 2023

Copy link
Copy Markdown
Member

Thanks for fixing this 🖤

vstinner added a commit that referenced this pull request Nov 10, 2023
@miss-islington@vstinner
[3.11] [3.12]gh-109181: Fix refleak in tb_get_lineno() (GH-111948) (#…
8222ad0
…111951)
[3.12] gh-109181: Fix refleak in tb_get_lineno() (GH-111948)
PyFrame_GetCode() returns a strong reference.
(cherry picked from commit 4b0c875)
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@pablogsal@iritkatriel