Uh oh!
There was an error while loading. Please reload this page.
gh-111789: Simplify import.c by using PyDict_GetItemRef() - #111979
Merged
serhiy-storchaka merged 2 commits intoNov 14, 2023
Conversation
vstinner
approved these changes
Nov 13, 2023
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. I just proposed a minor suggestion :-)
resolve_name() changes are non-trivial, but code handling (X)DECREF is at the end, so it's not too hard to review.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <vstinner@python.org>
aisk pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.