Skip to content

gh-108901: Deprecate inspect.getcallargs and slate it for removal - #112236

Open
sobolevn wants to merge 6 commits into
python:mainfrom
sobolevn:issue-108901-getcallargs
Open

gh-108901: Deprecate inspect.getcallargs and slate it for removal#112236
sobolevn wants to merge 6 commits into
python:mainfrom
sobolevn:issue-108901-getcallargs

Conversation

@sobolevn

@sobolevnsobolevn commented Nov 18, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Since this function already has a modern alternative and was deprecated since 3.5, I've added a runtime warning for this function and slated it for removal in two versions (3.15) from now.

📚 Documentation preview 📚: https://cpython-previews--112236.org.readthedocs.build/

@bedevere-appbedevere-appBot mentioned this pull request Nov 18, 2023
Open
AlexWaygood
AlexWaygood reviewed Nov 18, 2023
View reviewed changes
Comment threadLib/test/test_inspect/test_inspect.py Outdated
@sobolevn@AlexWaygood
Update Lib/test/test_inspect/test_inspect.py
1387814
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
terryjreedy
terryjreedy reviewed Nov 18, 2023
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2023-11-18-17-01-45.gh-issue-108901.T3p5ie.rst Outdated
terryjreedy
terryjreedy reviewed Nov 18, 2023
View reviewed changes
Comment threadDoc/whatsnew/3.13.rst Outdated
terryjreedy
terryjreedy reviewed Nov 18, 2023
View reviewed changes

@terryjreedyterryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with the details of code deprecation, but I improved the wording of the public announcements.

@sobolevn

sobolevn commented Nov 18, 2023

Copy link
Copy Markdown
MemberAuthor

@terryjreedy thank you!

@terryjreedy

terryjreedy commented Nov 18, 2023•
edited
Loading

Copy link
Copy Markdown
Member

The added code looks sensible but I would want someone more knowledgeable to check and a manual test of the notice.
EDIT: remove mistaken comment, and hide sobolevn's correct response thereto.

@sobolevn

This comment was marked as outdated.

Sign in to view
itamaro
itamaro reviewed Nov 20, 2023
View reviewed changes

@itamaroitamaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phrasing nits in the news and whatnew entries

Comment threadDoc/whatsnew/3.13.rst Outdated
Comment threadMisc/NEWS.d/next/Library/2023-11-18-17-01-45.gh-issue-108901.T3p5ie.rst Outdated
@sobolevn@itamaro
Apply suggestions from code review
bc0857f
Co-authored-by: Itamar Oren <itamarost@gmail.com>
AlexWaygood
AlexWaygood reviewed Nov 22, 2023
View reviewed changes
Comment threadDoc/library/inspect.rst Outdated
Comment threadLib/inspect.py Outdated
Comment threadMisc/NEWS.d/next/Library/2023-11-18-17-01-45.gh-issue-108901.T3p5ie.rst Outdated
Comment threadDoc/whatsnew/3.13.rst Outdated
Comment threadLib/test/test_inspect/test_inspect.py Outdated
@sobolevn@AlexWaygood
Apply suggestions from code review
3d98e87
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood approved these changes Nov 22, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexWaygood

AlexWaygood commented Nov 22, 2023

Copy link
Copy Markdown
Member

Ah, I see @hugovk asked for some changes in #108901 (comment) -- I'll hold off merging for now :)

@Wulian233

Wulian233 commented Apr 26, 2025

Copy link
Copy Markdown
Contributor

I also recently found this issue, which may have been forgotten here, and needs to be removed in the 3.16 if added in 3.14

@vstinner

vstinner commented Apr 29, 2025

Copy link
Copy Markdown
Member

@sobolevn: What's the status of your PR?

@sobolevn

sobolevn commented Apr 29, 2025

Copy link
Copy Markdown
MemberAuthor

I guess that I will have to start everything over in 3.15 :)

@github-actions

github-actionsBot commented Apr 14, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Apr 14, 2026
@hugovk

hugovk commented Apr 14, 2026

Copy link
Copy Markdown
Member

I guess that I will have to start everything over in 3.15 :)

You have 3 weeks, or start over in 3.16 :)

@github-actionsgithub-actionsBot removed the stale Stale PR or inactive for long period of time. label May 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itamaroitamaroitamaro left review comments
@terryjreedyterryjreedyterryjreedy left review comments
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes
@gpsheadgpsheadAwaiting requested review from gpshead
@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sobolevn@terryjreedy@AlexWaygood@Wulian233@vstinner@hugovk@itamaro