gh-112507 Detect Cygwin and MSYS with `uname` instead of `$OSTYPE` by J-M0 · Pull Request #112508 · python/cpython

J-M0 · 2023-11-29T01:46:32Z

$OSTYPE is not defined by POSIX and may not be present in other shells. uname is always available in any shell.

Issue: venv/scripts/common/activate should use uname instead of $OSTYPE to detect Cygwin and MSYS #112507

`$OSTYPE` is not defined by POSIX and may not be present in other shells. `uname` is always available in any shell.

vsajip · 2023-12-11T10:44:16Z

+ # transform D:\path\to\venv to /d/path/to/venv on MSYS
+ # and to /cygdrive/d/path/to/venv on Cygwin
+ VIRTUAL_ENV=$(cygpath "__VENV_DIR__")
+ export VIRTUAL_ENV


Just a minor point - why export on a separate line instead of export VIRTUAL_ENV=$(cygpath "__VENV_DIR__") as it was before?

Declaring and assigning a variable at the same time can mask the return value if the command fails. Doing them separately won't which can help with debugging and error handling.
https://www.shellcheck.net/wiki/SC2155

miss-islington-app · 2023-12-11T17:27:34Z

Thanks @J-M0 for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington-app · 2023-12-11T17:27:35Z

Thanks @J-M0 for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app · 2023-12-11T17:27:37Z

Sorry, @J-M0 and @vsajip, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d7b5f102319bb0389c5248e9ecf533eae4163424 3.11

miss-islington-app · 2023-12-11T17:27:50Z

Sorry, @J-M0 and @vsajip, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d7b5f102319bb0389c5248e9ecf533eae4163424 3.12

…YPE` (pythonGH-112508) Detect Cygwin and MSYS with `uname` instead of `$OSTYPE` `$OSTYPE` is not defined by POSIX and may not be present in other shells. `uname` is always available in any shell.

With python#112508 the check to change paths when running on Windows was changed from using the non-posix environment variable `$OSTYPE` to using `uname` instead. However this missed the fact that when running under MinGW shell, uname reports `MINGW*` (`$OSTYPE` is still `msys`). This results in `$PATH` being set to something like `D:\a\github-actions-shells\github-actions-shells\venv/Scripts:…`, instead of `/d/a/github-actions-shells/github-actions-shells/venv/Scripts`. Notably, the Git Bash shell for Windows behaves like this, and this is also the bash shell that’s used for GitHub Actions Windows runners.

With python#112508 the check to converts paths when running on Windows was changed from using the non-posix environment variable `$OSTYPE` to using `uname` instead. However this missed the fact that when running under Git Bash on Windows, uname reports `MINGW*` (`$OSTYPE` is still `msys`). This results in `$PATH` being set to something like `D:\a\github-actions-shells\github-actions-shells\venv/Scripts:…`, instead of `/d/a/github-actions-shells/github-actions-shells/venv/Scripts`. Notably, the Git Bash is the bash shell that’s used for GitHub Actions Windows runners, and ships with VSCode.

…under Windows (GH-125399) * Convert paths in venv activate script when using Git Bash under Windows With #112508 the check to converts paths when running on Windows was changed from using the non-posix environment variable `$OSTYPE` to using `uname` instead. However this missed the fact that when running under Git Bash on Windows, uname reports `MINGW*` (`$OSTYPE` is still `msys`). This results in `$PATH` being set to something like `D:\a\github-actions-shells\github-actions-shells\venv/Scripts:…`, instead of `/d/a/github-actions-shells/github-actions-shells/venv/Scripts`. Notably, the Git Bash is the bash shell that’s used for GitHub Actions Windows runners, and ships with VSCode.

… Bash under Windows (pythonGH-125399) * Convert paths in venv activate script when using Git Bash under Windows With python#112508 the check to converts paths when running on Windows was changed from using the non-posix environment variable `$OSTYPE` to using `uname` instead. However this missed the fact that when running under Git Bash on Windows, uname reports `MINGW*` (`$OSTYPE` is still `msys`). This results in `$PATH` being set to something like `D:\a\github-actions-shells\github-actions-shells\venv/Scripts:…`, instead of `/d/a/github-actions-shells/github-actions-shells/venv/Scripts`. Notably, the Git Bash is the bash shell that’s used for GitHub Actions Windows runners, and ships with VSCode. (cherry picked from commit 2a378db) Co-authored-by: Julien <julien@caffeine.lu>

… Bash under Windows (pythonGH-125399) * Convert paths in venv activate script when using Git Bash under Windows With python#112508 the check to converts paths when running on Windows was changed from using the non-posix environment variable `$OSTYPE` to using `uname` instead. However this missed the fact that when running under Git Bash on Windows, uname reports `MINGW*` (`$OSTYPE` is still `msys`). This results in `$PATH` being set to something like `D:\a\github-actions-shells\github-actions-shells\venv/Scripts:…`, instead of `/d/a/github-actions-shells/github-actions-shells/venv/Scripts`. Notably, the Git Bash is the bash shell that’s used for GitHub Actions Windows runners, and ships with VSCode.

hugovk · 2025-02-26T09:17:37Z

@J-M0 @vsajip Triage: is the 3.12 backport still needed? If so, please could you create it? Otherwise, let's remove the backport label.

…f `$OSTYPE` (pythonGH-112508) Detect Cygwin and MSYS with `uname` instead of `$OSTYPE` `$OSTYPE` is not defined by POSIX and may not be present in other shells. `uname` is always available in any shell. (cherry picked from commit d7b5f10) Co-authored-by: James Morris <6653392+J-M0@users.noreply.github.com>

bedevere-app · 2025-02-28T09:01:24Z

GH-130674 is a backport of this pull request to the 3.12 branch.

…TYPE` (GH-112508) (GH-130674) (cherry picked from commit d7b5f10)

Detect Cygwin and MSYS with uname instead of $OSTYPE
904b6e8
`$OSTYPE` is not defined by POSIX and may not be present in other shells. `uname` is always available in any shell.

J-M0 requested a review from vsajip as a code owner November 29, 2023 01:46

bedevere-appBot added the awaiting review label Nov 29, 2023

bedevere-appBot mentioned this pull request Nov 29, 2023
venv/scripts/common/activate should use uname instead of $OSTYPE to detect Cygwin and MSYS #112507
Closed

vsajip reviewed Dec 11, 2023
View reviewed changes

vsajip approved these changes Dec 11, 2023
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting review labels Dec 11, 2023

vsajip added the skip news label Dec 11, 2023

vsajip merged commit d7b5f10 into python:mainDec 11, 2023

bedevere-appBot removed the awaiting merge label Dec 11, 2023

vsajip added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Dec 11, 2023

miss-islington-appBot assigned vsajip Dec 11, 2023

J-M0 deleted the venv_ostype branch January 3, 2024 18:21

This was referenced Oct 13, 2024
The virtualenv activate script does not correctly detect the Windows Git Bash shell #125398
Closed
gh-125398: Convert paths in venv activate script when using Git Bash under Windows #125399
Merged

miss-islington mentioned this pull request Oct 19, 2024
[3.13] gh-125398: Convert paths in venv activate script when using Git Bash under Windows (GH-125399) #125733
Merged

ZeroIntensity removed the needs backport to 3.11 only security fixes label Feb 17, 2025

vsajip mentioned this pull request Feb 28, 2025
[3.12] gh-112507: Detect Cygwin and MSYS with uname instead of `$OS… #130674
Merged

bedevere-appBot removed the needs backport to 3.12 only security fixes label Feb 28, 2025

vsajip added a commit that referenced this pull request Feb 28, 2025
[3.12]gh-112507: Detect Cygwin and MSYS withunameinstead of `$OS…
4eb1421
…TYPE` (GH-112508) (GH-130674) (cherry picked from commit d7b5f10)

brianschubert mentioned this pull request Apr 10, 2025
Double parenthesis in activated venv generated by Python 3.12.10 #132361
Closed

LuNoX mentioned this pull request Jun 7, 2026
gh-151042: venv: Pass VIRTUAL_ENV through cygpath inside fish on Windows #151043
Merged

Navigation Menu

Uh oh!

Uh oh!

gh-112507 Detect Cygwin and MSYS with `uname` instead of `$OSTYPE` - #112508

gh-112507 Detect Cygwin and MSYS with `uname` instead of `$OSTYPE`#112508
vsajip merged 1 commit into
python:mainfrom
J-M0:venv_ostype

J-M0 commented Nov 29, 2023•
edited by bedevere-app Bot
Loading

Uh oh!

vsajipDec 11, 2023

Uh oh!

J-M0Dec 11, 2023

Uh oh!

miss-islington-appBot commented Dec 11, 2023

Uh oh!

miss-islington-appBot commented Dec 11, 2023

Uh oh!

miss-islington-appBot commented Dec 11, 2023

Uh oh!

miss-islington-appBot commented Dec 11, 2023

Uh oh!

hugovk commented Feb 26, 2025

Uh oh!

bedevere-appBot commented Feb 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

J-M0 commented Nov 29, 2023• edited by bedevere-app BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vsajipDec 11, 2023

Choose a reason for hiding this comment

Uh oh!

J-M0Dec 11, 2023

Choose a reason for hiding this comment

Uh oh!

miss-islington-appBot commented Dec 11, 2023

Uh oh!

miss-islington-appBot commented Dec 11, 2023

Uh oh!

miss-islington-appBot commented Dec 11, 2023

Uh oh!

miss-islington-appBot commented Dec 11, 2023

Uh oh!

hugovk commented Feb 26, 2025

Uh oh!

bedevere-appBot commented Feb 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

J-M0 commented Nov 29, 2023•
edited by bedevere-app Bot
Loading