Skip to content

gh-95754: Better AttributeError on partially initialised module - #112577

Merged
hauntsaninja merged 7 commits into
python:mainfrom
hauntsaninja:gh95754
Dec 21, 2023
Merged

gh-95754: Better AttributeError on partially initialised module#112577
hauntsaninja merged 7 commits into
python:mainfrom
hauntsaninja:gh95754

Conversation

@hauntsaninja

@hauntsaninjahauntsaninja commented Dec 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Dec 1, 2023
Closed
serhiy-storchaka
serhiy-storchaka reviewed Dec 1, 2023
View reviewed changes
Comment threadObjects/moduleobject.c Outdated
if (suppress != 1) {
if (_PyModuleSpec_IsInitializing(spec)) {
PyErr_Format(PyExc_AttributeError,
origin = PyObject_GetAttr(spec, &_Py_ID(origin));

@serhiy-storchakaserhiy-storchakaDec 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyObject_GetAttr() can set not only AttributeError. If it sets a different error, it should not be overridden by AttributeError.

I suggest to use PyObject_GetOptionalAttr().

@iritkatrieliritkatrielDec 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not chain the original error to a new exception (raise from)?

@iritkatrieliritkatrielDec 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe this is a use case for adding a note to the original exception and letting it propagate on (if we don't want to change the type of the exception being raised).

Comment threadObjects/moduleobject.c Outdated
serhiy-storchaka
serhiy-storchaka reviewed Dec 3, 2023
View reviewed changes
Comment threadObjects/moduleobject.c
@hauntsaninja

hauntsaninja commented Dec 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Thank you for the reviews!

@serhiy-storchaka

serhiy-storchaka commented Dec 7, 2023

Copy link
Copy Markdown
Member

I fixed some errors, please resolve conflicts.

serhiy-storchaka
serhiy-storchaka reviewed Dec 18, 2023
View reviewed changes
Comment threadObjects/moduleobject.c Outdated
serhiy-storchaka
serhiy-storchaka approved these changes Dec 18, 2023
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hauntsaninja
hauntsaninja merged commit 61e8184 into python:mainDec 21, 2023
@hauntsaninja
hauntsaninja deleted the gh95754 branch December 21, 2023 21:24
@hugovk

hugovk commented Dec 21, 2023

Copy link
Copy Markdown
Member

Would be great to mention this nice quality-of-life improvement with an example in What's New, similar to:

https://docs.python.org/3/whatsnew/3.12.html#improved-error-messages

ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
@hauntsaninja@serhiy-storchaka@ryan-duve
pythongh-95754: Better AttributeError on partially initialised module (…
7eadfa9
…python#112577)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@hauntsaninjahauntsaninja mentioned this pull request Jan 6, 2024
Merged
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@hauntsaninja@serhiy-storchaka@kulikjak
pythongh-95754: Better AttributeError on partially initialised module (…
17f31d6
…python#112577)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@hauntsaninja@serhiy-storchaka@aisk
pythongh-95754: Better AttributeError on partially initialised module (…
4bb2407
…python#112577)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@hauntsaninja@serhiy-storchaka@Glyphack
pythongh-95754: Better AttributeError on partially initialised module (…
c698237
…python#112577)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@hugovkhugovk mentioned this pull request Jun 29, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel left review comments
@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner
@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner
@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hauntsaninja@serhiy-storchaka@hugovk@iritkatriel