Skip to content

gh-109413: libregrtest: enable mypy's --strict-optional check on most files - #112586

Merged
AlexWaygood merged 6 commits into
python:mainfrom
AlexWaygood:libregrtest-easy-strict-optional
Dec 1, 2023
Merged

gh-109413: libregrtest: enable mypy's --strict-optional check on most files#112586
AlexWaygood merged 6 commits into
python:mainfrom
AlexWaygood:libregrtest-easy-strict-optional

Conversation

@AlexWaygood

@AlexWaygoodAlexWaygood commented Dec 1, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Mypy's --strict-optional check is one of its most important checks, and it's enabled by default when you run mypy. It warns you if it infers that an object might be of type Foo | None at runtime, even though the code is only guaranteed to work if the object is an instance of Foo.

We currently have --strict-optional disabled on several files, as there were too many errors to deal with initially, and the priority was to have mypy enabled in CI so that we could work on improving the type annotations incrementally. This PR re-enables --strict-optional on four files where it's easy to do so.

@bedevere-appbedevere-appBot mentioned this pull request Dec 1, 2023
Closed
vstinner
vstinner reviewed Dec 1, 2023
View reviewed changes
Comment threadLib/test/libregrtest/runtests.py Outdated
Comment threadLib/test/libregrtest/single.py
Comment threadLib/test/libregrtest/utils.py Outdated
AlexWaygood
AlexWaygood commented Dec 1, 2023
View reviewed changes
Comment threadLib/test/libregrtest/utils.py Outdated
@AlexWaygood

AlexWaygood commented Dec 1, 2023

Copy link
Copy Markdown
MemberAuthor

On hold until #112588 is merged

@AlexWaygood
AlexWaygood marked this pull request as draft December 1, 2023 13:10
vstinner
vstinner reviewed Dec 1, 2023
View reviewed changes
Comment threadLib/test/libregrtest/results.py Outdated
@AlexWaygood@vstinner
ValueError
028b8be
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
vstinner approved these changes Dec 1, 2023
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@AlexWaygood
AlexWaygood marked this pull request as ready for review December 1, 2023 13:49
@AlexWaygood
AlexWaygood enabled auto-merge (squash) December 1, 2023 13:55
@AlexWaygoodAlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Dec 1, 2023
@AlexWaygood
AlexWaygood merged commit 70a38ff into python:mainDec 1, 2023
@AlexWaygood
AlexWaygood deleted the libregrtest-easy-strict-optional branch December 1, 2023 14:54
@miss-islington-app

miss-islington-appBot commented Dec 1, 2023

Copy link
Copy Markdown

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Dec 1, 2023

Copy link
Copy Markdown

Sorry, @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 70a38ffb3d712f973eb17bd1bda541f238ae70d2 3.12

@miss-islington-app

miss-islington-appBot commented Dec 1, 2023

Copy link
Copy Markdown

Sorry, @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 70a38ffb3d712f973eb17bd1bda541f238ae70d2 3.11

AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Dec 1, 2023
@AlexWaygood@vstinner
pythongh-109413: libregrtest: enable mypy's--strict-optionalcheck…
26306e4
… on most files (python#112586)
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-appBot commented Dec 1, 2023

Copy link
Copy Markdown

GH-112602 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Dec 1, 2023
@AlexWaygoodAlexWaygood removed the needs backport to 3.11 only security fixes label Dec 1, 2023
@AlexWaygood

AlexWaygood commented Dec 1, 2023

Copy link
Copy Markdown
MemberAuthor

I added the "needs backport to 3.11" label to the 3.12 branch to take care of the 3.11 backport.

AlexWaygood added a commit that referenced this pull request Dec 1, 2023
@AlexWaygood@vstinner
[3.12]gh-109413: libregrtest: enable mypy's--strict-optionalchec…
36dbebe
…k on most files (#112586) (#112602)
gh-109413: libregrtest: enable mypy's `--strict-optional` check on most files (#112586)
Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islingtonmiss-islington mentioned this pull request Dec 1, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 1, 2023
@AlexWaygood@vstinner@miss-islington
[3.12]pythongh-109413: libregrtest: enable mypy's `--strict-optional…
f4d2bdd
…` check on most files (pythonGH-112586) (pythonGH-112602)
pythongh-109413: libregrtest: enable mypy's `--strict-optional` check on most files (pythonGH-112586)
(cherry picked from commit 36dbebe)
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
AlexWaygood added a commit that referenced this pull request Dec 1, 2023
@miss-islington@AlexWaygood@vstinner
[3.11] [3.12]gh-109413: libregrtest: enable mypy's `--strict-optiona…
da33204
…l` check on most files (GH-112586) (GH-112602) (#112603)
[3.12] gh-109413: libregrtest: enable mypy's `--strict-optional` check on most files (GH-112586) (GH-112602)
gh-109413: libregrtest: enable mypy's `--strict-optional` check on most files (GH-112586)
(cherry picked from commit 36dbebe)
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@AlexWaygood@vstinner@aisk
pythongh-109413: libregrtest: enable mypy's--strict-optionalcheck…
0749ad2
… on most files (python#112586)
Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AlexWaygood@vstinner@Glyphack
pythongh-109413: libregrtest: enable mypy's--strict-optionalcheck…
492a7da
… on most files (python#112586)
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

@AlexWaygoodAlexWaygood

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexWaygood@vstinner