Skip to content

gh-112536: Add support for thread sanitizer (TSAN) - #112648

Merged
corona10 merged 8 commits into
python:mainfrom
samety:gh-112536_with-thread-sanitizer
Dec 30, 2023
Merged

gh-112536: Add support for thread sanitizer (TSAN)#112648
corona10 merged 8 commits into
python:mainfrom
samety:gh-112536_with-thread-sanitizer

Conversation

@samety

@sametysamety commented Dec 3, 2023•
edited by colesbury
Loading

Copy link
Copy Markdown
Contributor

Adds --with-thread-sanitizer as a configure option and defines _Py_THREAD_SANITIZER when thread sanitizer is enabled.

📚 Documentation preview 📚: https://cpython-previews--112648.org.readthedocs.build/

@bedevere-appbedevere-appBot mentioned this pull request Dec 3, 2023
Closed
@colesbury

colesbury commented Dec 13, 2023

Copy link
Copy Markdown
Contributor

@samety - this looks good. When you feel the PR is ready, please mark it as "ready for review"

@colesbury

colesbury commented Dec 13, 2023

Copy link
Copy Markdown
Contributor

Oh, and I think this change should have a NEWS entry. (Use the "blurb" tool: https://pypi.org/project/blurb/)

@samety
samety marked this pull request as ready for review December 17, 2023 17:24
@sametysamety mentioned this pull request Dec 17, 2023
Closed
@corona10corona10 self-assigned this Dec 17, 2023
colesbury
colesbury approved these changes Dec 18, 2023
View reviewed changes

@colesburycolesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

FYI, I updated the PR message.

@colesbury

colesbury commented Dec 18, 2023

Copy link
Copy Markdown
Contributor

We'll want to make some changes after this. For example, I think we'll want to define MI_TSAN to 1 when _Py_THREAD_SANITIZER is defined. But those can be done in later PRs as we find and fix thread sanitizer issues.

@erlend-aasland
erlend-aasland removed their request for review December 18, 2023 21:53
@corona10

corona10 commented Dec 26, 2023

Copy link
Copy Markdown
Member

Sorry for the delay, I will take a look at this PR by end of this week.

@corona10
corona10 merged commit 88cb972 into python:mainDec 30, 2023
@samety
samety deleted the gh-112536_with-thread-sanitizer branch December 30, 2023 12:22
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@samety@kulikjak
pythongh-112536: Add support for thread sanitizer (TSAN) (pythongh-11…
0a51506
…2648)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@samety@aisk
pythongh-112536: Add support for thread sanitizer (TSAN) (pythongh-11…
001cf08
…2648)
@corona10corona10 mentioned this pull request Mar 10, 2024
Merged
pitrou pushed a commit to pitrou/cpython that referenced this pull request Mar 17, 2024
@samety@pitrou
[3.12]pythongh-112536: Add support for thread sanitizer (TSAN) (pyth…
11e1ba6
…ongh-112648)
(cherry picked from commit 88cb972)
Co-authored-by: Samet YASLAN <sametyaslan@gmail.com>
@bedevere-app

bedevere-appBot commented Mar 17, 2024

Copy link
Copy Markdown

GH-116924 is a backport of this pull request to the 3.12 branch.

@bedevere-app

bedevere-appBot commented Mar 17, 2024

Copy link
Copy Markdown

GH-116926 is a backport of this pull request to the 3.11 branch.

pitrou added a commit that referenced this pull request Mar 17, 2024
@pitrou@samety
[3.12]gh-112536: Add support for thread sanitizer (TSAN) (gh-112648) (…
2ac1b48
…#116924)
* [3.12] gh-112536: Add support for thread sanitizer (TSAN) (gh-112648)
(cherry picked from commit 88cb972)
* Remove doc for configure option (leave it hidden in this branch)
---------
Co-authored-by: Samet YASLAN <sametyaslan@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@samety@Glyphack
pythongh-112536: Add support for thread sanitizer (TSAN) (pythongh-11…
f54c75e
…2648)
@bedevere-app

bedevere-appBot commented Sep 8, 2024

Copy link
Copy Markdown

GH-123833 is a backport of this pull request to the 3.10 branch.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes
@corona10corona10corona10 approved these changes

Assignees

@corona10corona10

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samety@colesbury@corona10