Uh oh!
There was an error while loading. Please reload this page.
gh-99180: Remove traceback anchors in return and assign statements that cover all the displayed range - #112670
Conversation
bb342a0 to
6e941e1CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pablogsal
commented
Jan 8, 2024
Hey @lysnikolaou, can you check if this is more or less what you had in mind? (I will rebase soon) |
…nts that cover all the displayed range Signed-off-by: Pablo Galindo <pablogsal@gmail.com> Apply suggestions from code review Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> fix whitespace issue causing the lint check to fail
lysnikolaou
left a comment
There was a problem hiding this comment.
This looks a lot like what I had in mind and seeing the implementation I think it's a step towards the right direction!
lysnikolaou
commented
Feb 26, 2024
@pablogsal Let's merge this? |
bedevere-bot
commented
May 1, 2024
|
…nts that cover all the displayed range (python#112670)
| return ''.join(row) | ||
| def should_show_carets(self, start_offset, end_offset, all_lines, anchors): |
There was a problem hiding this comment.
Is this method meant to be a public-API method on StackSummary objects, or is it meant to be private API? If the former, we should probably document it at https://docs.python.org/3.13/library/traceback.html#stacksummary-objects. If the latter, maybe it should have a name prefixed with an underscore?
There was a problem hiding this comment.
It should be private so I am fine prefixing it with an underscore
returnand simple assignment statements #99180