Skip to content

gh-101100: Properly document frame object attributes - #112735

Merged
AlexWaygood merged 5 commits into
python:mainfrom
AlexWaygood:frameobject-attr-nitpicks
Dec 5, 2023
Merged

gh-101100: Properly document frame object attributes#112735
AlexWaygood merged 5 commits into
python:mainfrom
AlexWaygood:frameobject-attr-nitpicks

Conversation

@AlexWaygood

@AlexWaygoodAlexWaygood commented Dec 5, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

This PR fixes 10 or so Sphinx nitpicks in the datamodel docs. It also gives us anchors to link to across the rest of the documentation.

📚 Documentation preview 📚: https://cpython-previews--112735.org.readthedocs.build/

@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news labels Dec 5, 2023
@bedevere-appbedevere-appBot mentioned this pull request Dec 5, 2023
Closed
@AlexWaygoodAlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Dec 5, 2023
@AlexWaygood
AlexWaygood marked this pull request as ready for review December 5, 2023 00:33
@AlexWaygood

AlexWaygood commented Dec 5, 2023

Copy link
Copy Markdown
MemberAuthor

Docs preview: https://cpython-previews--112735.org.readthedocs.build/en/112735/reference/datamodel.html#frame-objects

AlexWaygood
AlexWaygood commented Dec 5, 2023
View reviewed changes
Comment threadDoc/whatsnew/3.7.rst Outdated
@AlexWaygood
AlexWaygood merged commit d109f63 into python:mainDec 5, 2023
@AlexWaygood
AlexWaygood deleted the frameobject-attr-nitpicks branch December 5, 2023 19:28
@miss-islington-app

miss-islington-appBot commented Dec 5, 2023

Copy link
Copy Markdown

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Dec 5, 2023

Copy link
Copy Markdown

Sorry, @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d109f637c048c2b5fc95dc7fdfd50f8ac41a7747 3.11

@bedevere-app

bedevere-appBot commented Dec 5, 2023

Copy link
Copy Markdown

GH-112772 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2023
@AlexWaygood@miss-islington
pythongh-101100: Properly document frame object attributes (pythonGH-…
b96c75d
…112735)
(cherry picked from commit d109f63)
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Dec 5, 2023
AlexWaygood added a commit that referenced this pull request Dec 5, 2023
@miss-islington@AlexWaygood
[3.12]gh-101100: Properly document frame object attributes (GH-112735)…
ef92e9e
… (#112772)
gh-101100: Properly document frame object attributes (GH-112735)
(cherry picked from commit d109f63)
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app

bedevere-appBot commented Dec 5, 2023

Copy link
Copy Markdown

GH-112775 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Dec 5, 2023
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Dec 5, 2023
@AlexWaygood
[3.11]pythongh-101100: Properly document frame object attributes (py…
d7c70cd
…thon#112735)
(cherry-picked from commit d109f63)
AlexWaygood added a commit that referenced this pull request Dec 5, 2023
@AlexWaygood
[3.11]gh-101100: Properly document frame object attributes (#112735) (…
c26d6c1
…#112775)
* [3.11] gh-101100: Properly document frame object attributes (#112735)
(cherry-picked from commit d109f63)
@AlexWaygoodAlexWaygood mentioned this pull request Dec 31, 2023
Open
@AlexWaygoodAlexWaygood mentioned this pull request Jan 19, 2024
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@AlexWaygood@aisk
pythongh-101100: Properly document frame object attributes (python#11…
c45ae36
…2735)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AlexWaygood@Glyphack
pythongh-101100: Properly document frame object attributes (python#11…
a6478b0
…2735)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

@AlexWaygoodAlexWaygood

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexWaygood@serhiy-storchaka