Skip to content

gh-108927: Include new dir test/regrtestdata in the installation - #112765

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:makefile-TESTSUBDIRS-test/regrtestdata
Dec 6, 2023
Merged

gh-108927: Include new dir test/regrtestdata in the installation#112765
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:makefile-TESTSUBDIRS-test/regrtestdata

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Dec 5, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Dec 5, 2023
Closed
@serhiy-storchakaserhiy-storchaka mentioned this pull request Dec 5, 2023
Merged
@serhiy-storchakaserhiy-storchaka added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Dec 5, 2023
@bedevere-bot

bedevere-bot commented Dec 5, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 6a3ef06 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 5, 2023
@serhiy-storchaka

serhiy-storchaka commented Dec 5, 2023

Copy link
Copy Markdown
MemberAuthor

Seems that it doesn't help.

vstinner
vstinner approved these changes Dec 5, 2023
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vstinner
vstinner reviewed Dec 5, 2023
View reviewed changes
Comment threadMakefile.pre.in
@vstinner

vstinner commented Dec 5, 2023

Copy link
Copy Markdown
Member

@serhiy-storchaka: I pushed directly to your branch (using GitHub suggestions) to unblock the Python 3.12 release for @Yhg1s.

@vstinner

vstinner commented Dec 5, 2023

Copy link
Copy Markdown
Member

With this change, test_regrtest pass on an installed Python.

@serhiy-storchaka
serhiy-storchaka merged commit f8c0198 into python:mainDec 6, 2023
@serhiy-storchaka
serhiy-storchaka deleted the makefile-TESTSUBDIRS-test/regrtestdata branch December 6, 2023 07:48
@serhiy-storchaka

serhiy-storchaka commented Dec 6, 2023

Copy link
Copy Markdown
MemberAuthor

Thank you, @vstinner.

@serhiy-storchakaserhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Dec 6, 2023
@miss-islington-app

miss-islington-appBot commented Dec 6, 2023

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

miss-islington-appBot commented Dec 6, 2023

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Dec 6, 2023

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f8c0198e3bfa2f6f65e426765a5efddd8ece78b0 3.11

@miss-islington-app

miss-islington-appBot commented Dec 6, 2023

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f8c0198e3bfa2f6f65e426765a5efddd8ece78b0 3.12

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Dec 6, 2023
@serhiy-storchaka@vstinner
[3.11]pythongh-108927: Include new dir test/regrtestdata in the inst…
669d55a
…allation (pythonGH-112765)
(cherry picked from commit f8c0198)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@serhiy-storchakaserhiy-storchaka mentioned this pull request Dec 6, 2023
Merged
@bedevere-app

bedevere-appBot commented Dec 6, 2023

Copy link
Copy Markdown

GH-112784 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Dec 6, 2023
@serhiy-storchakaserhiy-storchaka mentioned this pull request Dec 6, 2023
Merged
@bedevere-app

bedevere-appBot commented Dec 6, 2023

Copy link
Copy Markdown

GH-112785 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Dec 6, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Dec 6, 2023
@serhiy-storchaka@vstinner
[3.12]pythongh-108927: Include new dir test/regrtestdata in the inst…
89ec85e
…allation (pythonGH-112765)
(cherry picked from commit f8c0198)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
serhiy-storchaka added a commit that referenced this pull request Dec 6, 2023
@serhiy-storchaka@vstinner
[3.11]gh-108927: Include new dir test/regrtestdata in the installati…
f92c8bf
…on (GH-112765) (GH-112784)
(cherry picked from commit f8c0198)
Co-authored-by: Victor Stinner <vstinner@python.org>
serhiy-storchaka added a commit that referenced this pull request Dec 6, 2023
@serhiy-storchaka@vstinner
[3.12]gh-108927: Include new dir test/regrtestdata in the installati…
cf16aaa
…on (GH-112765) (GH-112785)
(cherry picked from commit f8c0198)
Co-authored-by: Victor Stinner <vstinner@python.org>
hrnciar pushed a commit to fedora-python/cpython that referenced this pull request Dec 6, 2023
@serhiy-storchaka@vstinner@hrnciar
00371: Include new dir test/regrtestdata in the installation (pythonG…
54fbd59
…H-112765) (pythonGH-112784)
(cherry picked from commit f8c0198)
Co-authored-by: Victor Stinner <vstinner@python.org>
hrnciar pushed a commit to fedora-python/cpython that referenced this pull request Dec 7, 2023
@serhiy-storchaka@vstinner@hrnciar
00412: Include new dir test/regrtestdata in the installation (pythonG…
c41b95e
…H-112765) (pythonGH-112784)
(cherry picked from commit f8c0198)
Co-authored-by: Victor Stinner <vstinner@python.org>
@serhiy-storchakaserhiy-storchaka mentioned this pull request Dec 15, 2023
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka@vstinner@aisk
pythongh-108927: Include new dir test/regrtestdata in the installation (
7c43b81
pythonGH-112765)
Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka@vstinner@Glyphack
pythongh-108927: Include new dir test/regrtestdata in the installation (
35d3c68
pythonGH-112765)
Co-authored-by: Victor Stinner <vstinner@python.org>
@serhiy-storchakaserhiy-storchaka removed their assignment Jul 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@Yhg1sYhg1sYhg1s approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka@bedevere-bot@vstinner@Yhg1s