Uh oh!
There was an error while loading. Please reload this page.
gh-108223: Refer to PEP 703 as Free Threading - #112780
Conversation
vstinner
commented
Dec 5, 2023
Should the See the steering council decision: python/steering-council#221 (comment) |
corona10
commented
Dec 5, 2023
cc @hugovk |
corona10
commented
Dec 5, 2023
Ah okay, python/steering-council#221 (comment) was announced 2 hours ago. |
vstinner
commented
Dec 5, 2023
Naming is hard :-) The update is that the Steering Council took a decision. But this PR is not about Py_GIL_DISABLED macro which can be renamed in a following PR if needed. |
itamaro
commented
Dec 6, 2023
I'm confused. Didn't the SC decision explicitly mention that Py_GIL_DISABLED is ok? |
I have the same opinion as @itamaro |
hugovk
commented
Dec 6, 2023
No, we keep The SC said yesterday:
python/steering-council#221 (comment) This PR doesn't touch the macro though. It changes a constant used by unit tests. This isn't exposed to users, so we could keep it as is, but are also free to change it. However, because the constant is directly looking up the macro value from |
Uh oh!
There was an error while loading. Please reload this page.
| # --disable-gil | ||
| if sysconfig.get_config_var('Py_GIL_DISABLED'): | ||
| build.append("nogil") | ||
| build.append("freethreading") |
There was a problem hiding this comment.
?
| build.append("freethreading") | |
| build.append("gil_disabled") |
vstinner
commented
Dec 6, 2023
I updated the PR. Please review it again.
Oh ok. I read the announcement too quickly, I missed the part about Py_GIL_DISABLED.
Ok, I updated my PR for that. @hugovk proposed |
vstinner
commented
Dec 6, 2023
Merged, thanks for reviews. |
Rename support.Py_GIL_DISABLED to support.FREE_THREADING.
📚 Documentation preview 📚: https://cpython-previews--112780.org.readthedocs.build/