Skip to content

gh-111964: Add _PyRWMutex a "readers-writer" lock - #112859

Merged
ericsnowcurrently merged 6 commits into
python:mainfrom
colesbury:rwmutex
Dec 16, 2023
Merged

gh-111964: Add _PyRWMutex a "readers-writer" lock#112859
ericsnowcurrently merged 6 commits into
python:mainfrom
colesbury:rwmutex

Conversation

@colesbury

@colesburycolesbury commented Dec 7, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This adds _PyRWMutex, a "readers-writer" lock, which wil be used to
serialize global stop-the-world pauses with per-interpreter pauses.

@colesbury
pythongh-111964: Add_PyRWMutexa "readers-writer" lock
fd61525
This adds `_PyRWMutex`, a "readers-writer" lock, which wil be used to
serialize global stop-the-world pauses with per-interpreter pauses.
@colesbury
Add comments and ASCII diagram based on review.
c6b9d62
Also, fix bug where `_PyRWMutex_Lock()` swapped the
return/continue conditions leading to an extra iteration of the loop.
@bedevere-appbedevere-appBot mentioned this pull request Dec 7, 2023
Closed
@colesbury
colesbury marked this pull request as ready for review December 7, 2023 22:46
@colesburycolesbury mentioned this pull request Dec 7, 2023
Merged
ericsnowcurrently
ericsnowcurrently requested changes Dec 13, 2023
View reviewed changes

@ericsnowcurrentlyericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to split this out and address the other review comments I left on gh-112471. I've left a few here, including what might be a bug.

Comment threadInclude/internal/pycore_lock.h
Comment threadPython/lock.c
Comment threadPython/lock.c
Comment threadPython/lock.c
Comment threadPython/lock.c
Comment threadPython/lock.c
Comment threadInclude/internal/pycore_lock.h Outdated
@bedevere-app

bedevere-appBot commented Dec 13, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ericsnowcurrently
ericsnowcurrently reviewed Dec 13, 2023
View reviewed changes
Comment threadInclude/internal/pycore_lock.h Outdated
@colesbury
Update comments and add assertions.
e8419d7
Also describe _PyRWMutex using bit patterns instead of ASCII art box. This
matches how PyMutex is described.
ericsnowcurrently
ericsnowcurrently approved these changes Dec 14, 2023
View reviewed changes

@ericsnowcurrentlyericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colesbury

colesbury commented Dec 14, 2023

Copy link
Copy Markdown
ContributorAuthor

(Fixed a typo in _PyRWMutex_RUnlock)

@ericsnowcurrently

ericsnowcurrently commented Dec 15, 2023

Copy link
Copy Markdown
Member

@colesbury, I'm planning on merging this in the next hour or two. Let me know if you want me to wait.

@colesbury

colesbury commented Dec 15, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks - it's good to go now.

@ericsnowcurrently
ericsnowcurrently merged commit 5ae75e1 into python:mainDec 16, 2023
@colesbury
colesbury deleted the rwmutex branch December 19, 2023 14:57
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@colesbury@aisk
pythongh-111964: Add _PyRWMutex a "readers-writer" lock (pythongh-112859
1101a68
)
This adds `_PyRWMutex`, a "readers-writer" lock, which wil be used to
serialize global stop-the-world pauses with per-interpreter pauses.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@colesbury@Glyphack
pythongh-111964: Add _PyRWMutex a "readers-writer" lock (pythongh-112859
09eb4f0
)
This adds `_PyRWMutex`, a "readers-writer" lock, which wil be used to
serialize global stop-the-world pauses with per-interpreter pauses.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

Assignees

No one assigned

Labels

3.13bugs and security fixesskip newstopic-C-APItopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@colesbury@ericsnowcurrently