Uh oh!
There was an error while loading. Please reload this page.
gh-112205: Support @setter annotation from AC - #112922
Conversation
Uh oh!
There was an error while loading. Please reload this page.
@setter annotation from AC@setter annotation from AC@colesbury@erlend-aasland@AlexWaygood
|
Uh oh!
There was an error while loading. Please reload this page.
@setter annotation from AC@setter annotation from ACcorona10
commented
Dec 10, 2023
For the dev guide, I will send a PR once the PR is landed. |
corona10
commented
Dec 10, 2023
And also, we need to consider supporting PyDoc for getter/setter with the separated PR. Lines 181 to 186 in 384d6c1 |
erlend-aasland
left a comment
There was a problem hiding this comment.
Overall this looks good to me; thanks!
I would prefer to use a naming aligned with the names already used in the C API (tp_getset, PyGetSetDef); that is, consistently use getset and GETSET instead of getsetter and GETSETTER.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland
left a comment
There was a problem hiding this comment.
Oops, I probably introduced a typo with my recent suggestions; sorry 'bout that!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
corona10
commented
Dec 11, 2023
@erlend-aasland Thank you nice catch! PTAL one more time |
erlend-aasland
left a comment
There was a problem hiding this comment.
LGTM. Let's wait for Alex to chime in.
(cc. @colesbury, if you'd like to take a look.)
AlexWaygood
commented
Dec 12, 2023
(I'm travelling right now, but will do my best to review this tomorrow or Wednesday!) |
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks! A few small suggestions, mostly to do with error messages:
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
--------- Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
--------- Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Uh oh!
There was an error while loading. Please reload this page.