Skip to content

GH-111485: Factor out tier 2 code generation from the rest of the interpreter code generator - #112968

Merged
markshannon merged 9 commits into
python:mainfrom
faster-cpython:tier-2-code-gen
Dec 12, 2023
Merged

GH-111485: Factor out tier 2 code generation from the rest of the interpreter code generator#112968
markshannon merged 9 commits into
python:mainfrom
faster-cpython:tier-2-code-gen

Conversation

@markshannon

@markshannonmarkshannon commented Dec 11, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Dec 11, 2023
Closed
iritkatriel
iritkatriel reviewed Dec 11, 2023
View reviewed changes
Comment threadTools/cases_generator/tier2_generator.py
Comment threadTools/cases_generator/tier2_generator.py
Comment threadTools/cases_generator/analyzer.py
Comment threadPython/executor_cases.c.h Outdated
gvanrossum
gvanrossum reviewed Dec 12, 2023
View reviewed changes

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits. Please also use black on all files you touched.

Comment threadPython/executor_cases.c.h Outdated
Comment threadTools/cases_generator/analyzer.py
Comment threadTools/cases_generator/uop_id_generator.py Outdated
Comment threadTools/cases_generator/uop_id_generator.py Outdated
Comment threadTools/cases_generator/tier1_generator.py
out.emit(f"{type}{var.name};\n")


def emit_to(out: CWriter, tkn_iter: Iterator[Token], end: str) -> None:

@gvanrossumgvanrossumDec 11, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make any changes to the code that you moved to generators_common.py or stack.py? Or is it strictly a move?

@markshannonmarkshannonDec 12, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strictly a move

Comment threadTools/cases_generator/tier2_generator.py
Comment threadTools/cases_generator/tier2_generator.py
Comment threadTools/cases_generator/generators_common.py
)


def emit_to(out: CWriter, tkn_iter: Iterator[Token], end: str) -> None:

@gvanrossumgvanrossumDec 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a method on CWriter.

@markshannonmarkshannonDec 12, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but it tracks the parentheses in the tkn_iter input, which seems out of scope for a writer.

Comment threadTools/cases_generator/tier2_generator.py
@markshannon
markshannon merged commit 0c55f27 into python:mainDec 12, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@markshannon@aisk
pythonGH-111485: Factor out tier 2 code generation from the rest of t…
cd18c36
…he interpreter code generator (pythonGH-112968)
@markshannon
markshannon deleted the tier-2-code-gen branch August 6, 2024 10:18
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@markshannon@Glyphack
pythonGH-111485: Factor out tier 2 code generation from the rest of t…
348f9c0
…he interpreter code generator (pythonGH-112968)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum left review comments
@iritkatrieliritkatrieliritkatriel approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon@iritkatriel@gvanrossum