Skip to content

GH-111485: Mark some instructions as TIER_ONE_ONLY - #113155

Merged
markshannon merged 2 commits into
python:mainfrom
brandtbucher:non-viable-uops
Dec 15, 2023
Merged

GH-111485: Mark some instructions as TIER_ONE_ONLY#113155
markshannon merged 2 commits into
python:mainfrom
brandtbucher:non-viable-uops

Conversation

@brandtbucher

@brandtbucherbrandtbucher commented Dec 15, 2023

Copy link
Copy Markdown
Member

Recent refactoring has made it so that the interpreter generator is now emitting executor cases for some instructions that were implicitly non-viable as uops before. This marks those instructions as explicitly TIER_ONE_ONLY.

@brandtbucherbrandtbucher added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) build The build process and cross-build labels Dec 15, 2023
@brandtbucherbrandtbucher self-assigned this Dec 15, 2023

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvanrossum

Copy link
Copy Markdown
Member

Maybe eventually the tier-one-only marker could be one of the instruction attributes (like pure, replaced etc.) that go before the inst or op, instead of a weird magical line at the top of the code block?

@brandtbucher

Copy link
Copy Markdown
MemberAuthor

Yeah, I would like that too.

The less we need to poke around in the token soup (and keep things in the DSL header) the better.

@gvanrossum

gvanrossum commented Dec 15, 2023 via email

Copy link
Copy Markdown
Member

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildThe build process and cross-buildinterpreter-core(Objects, Python, Grammar, and Parser dirs)skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@brandtbucher@gvanrossum@markshannon