Skip to content

gh-112205: Require @getter and @setter to be methods - #113278

Merged
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:clinic/getset-guard
Dec 19, 2023
Merged

gh-112205: Require @getter and @setter to be methods#113278
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:clinic/getset-guard

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Dec 19, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Dec 19, 2023
Closed
erlend-aasland
erlend-aasland commented Dec 19, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
AlexWaygood
AlexWaygood reviewed Dec 19, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- could you add a test? ;)

Comment threadTools/clinic/clinic.py Outdated
erlend-aaslandand others added 3 commits December 19, 2023 11:32
@erlend-aasland@AlexWaygood
Update Tools/clinic/clinic.py
e0a3f6a
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aasland
Sync with main
45a2e32
@erlend-aasland
Sync with PR
fefab17
@erlend-aaslanderlend-aasland changed the title gh-112205: Require @getter and @setter to be class methodsgh-112205: Require @getter and @setter to be methodsDec 19, 2023
AlexWaygood
AlexWaygood approved these changes Dec 19, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erlend-aasland
erlend-aasland merged commit 6a69b80 into python:mainDec 19, 2023
@erlend-aasland
erlend-aasland deleted the clinic/getset-guard branch December 19, 2023 11:32
@corona10corona10 mentioned this pull request Dec 19, 2023
Merged
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
@erlend-aasland@AlexWaygood@ryan-duve
pythongh-112205: Require@Getterand@Setterto be methods (python#11…
586355d
…3278)
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@erlend-aasland@AlexWaygood@aisk
pythongh-112205: Require@Getterand@Setterto be methods (python#11…
a1284ea
…3278)
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@erlend-aasland@AlexWaygood@Glyphack
pythongh-112205: Require@Getterand@Setterto be methods (python#11…
78f1dc5
…3278)
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erlend-aasland@AlexWaygood