Skip to content

gh-113212: Improve error message & document zero-arg super inside nested functions and generator expressions - #113307

Merged
serhiy-storchaka merged 4 commits into
python:mainfrom
WolframAlph:zero-arg-super
Dec 22, 2023
Merged

gh-113212: Improve error message & document zero-arg super inside nested functions and generator expressions#113307
serhiy-storchaka merged 4 commits into
python:mainfrom
WolframAlph:zero-arg-super

Conversation

@WolframAlph

@WolframAlphWolframAlph commented Dec 20, 2023•
edited by AlexWaygood
Loading

Copy link
Copy Markdown
Contributor

@WolframAlphWolframAlph changed the title Improve error message & document arg super inside nested functions and generator expressionsgh-113212: Improve error message & document arg super inside nested functions and generator expressionsDec 20, 2023
@bedevere-appbedevere-appBot mentioned this pull request Dec 20, 2023
Closed
AlexWaygood
AlexWaygood reviewed Dec 20, 2023
View reviewed changes
Comment threadDoc/library/functions.rst Outdated
Comment threadDoc/library/functions.rst Outdated
Comment threadDoc/library/functions.rst Outdated
Comment threadDoc/library/functions.rst Outdated
@WolframAlphWolframAlph changed the title gh-113212: Improve error message & document arg super inside nested functions and generator expressionsgh-113212: Improve error message & document zero-arg super inside nested functions and generator expressionsDec 20, 2023
@Eclips4
Eclips4 requested a review from carljmDecember 20, 2023 18:39
Eclips4
Eclips4 reviewed Dec 20, 2023
View reviewed changes
Comment threadObjects/typeobject.c Outdated
AlexWaygood
AlexWaygood reviewed Dec 20, 2023
View reviewed changes
Comment threadDoc/library/functions.rst
@WolframAlph
WolframAlphforce-pushed the zero-arg-super branch 3 times, most recently from adb9e79 to 9fdccb7CompareDecember 20, 2023 20:10
carljm
carljm requested changes Dec 21, 2023
View reviewed changes

@carljmcarljm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! This direction looks right to me; I have some thoughts inline about how to tweak the approach.

Comment threadMisc/NEWS.d/next/Core and Builtins/2023-12-20-08-54-54.gh-issue-113212.62AUlw.rst Outdated
Comment threadObjects/typeobject.c Outdated
Comment threadDoc/library/functions.rst Outdated
@bedevere-app

bedevere-appBot commented Dec 21, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

carljm
carljm approved these changes Dec 21, 2023
View reviewed changes

@carljmcarljm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks @WolframAlph for the contribution. @AlexWaygood, any review comments before I merge?

serhiy-storchaka
serhiy-storchaka reviewed Dec 22, 2023
View reviewed changes
Comment threadObjects/typeobject.c Outdated
serhiy-storchaka
serhiy-storchaka reviewed Dec 22, 2023
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except PEP 7 and PEP 8 nitpicks. Some lines in C and Python code exceed the limit, please break them.

AlexWaygood
AlexWaygood reviewed Dec 22, 2023
View reviewed changes
Comment threadDoc/library/functions.rst Outdated
AlexWaygood
AlexWaygood reviewed Dec 22, 2023
View reviewed changes
Comment threadLib/test/test_super.py Outdated
@AlexWaygood
AlexWaygood removed their request for review December 22, 2023 14:05
serhiy-storchaka
serhiy-storchaka approved these changes Dec 22, 2023
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka
serhiy-storchaka merged commit 4a3d241 into python:mainDec 22, 2023
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
@WolframAlph@ryan-duve
pythongh-113212: Improve error message & document zero-arg super insi…
63be6bb
…de nested functions and generator expressions (pythonGH-113307)
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@WolframAlph@kulikjak
pythongh-113212: Improve error message & document zero-arg super insi…
e0d9344
…de nested functions and generator expressions (pythonGH-113307)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@WolframAlph@aisk
pythongh-113212: Improve error message & document zero-arg super insi…
d9c6bb1
…de nested functions and generator expressions (pythonGH-113307)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@WolframAlph@Glyphack
pythongh-113212: Improve error message & document zero-arg super insi…
b14185e
…de nested functions and generator expressions (pythonGH-113307)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljmcarljmcarljm approved these changes
@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner
@Eclips4Eclips4Awaiting requested review from Eclips4

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@WolframAlph@carljm@serhiy-storchaka@AlexWaygood@Eclips4