Skip to content

gh-113299: Create libclinic package - #113309

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:libclinic_converters
Closed

gh-113299: Create libclinic package#113309
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:libclinic_converters

Conversation

@vstinner

@vstinnervstinner commented Dec 20, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member
  • Create Tools/clinic/libclinic/ package.
  • Move cpp.py to libclinic.
  • Create libclinic.utils.

@vstinner
pythongh-113299: Create libclinic package
b58b260
* Create Tools/clinic/libclinic/ package.
* Move cpp.py to libclinic.
* Create libclinic.utils.
@bedevere-appbedevere-appBot mentioned this pull request Dec 20, 2023
Closed
@vstinner

vstinner commented Dec 20, 2023

Copy link
Copy Markdown
MemberAuthor

@erlend-aasland@AlexWaygood@corona10: Ok, here is first minimum step to create a new package for Argument Clinic code.

AlexWaygood
AlexWaygood reviewed Dec 20, 2023
View reviewed changes
Comment threadTools/clinic/libclinic/utils.py


# Clinic instance
clinic: 'Clinic' | None = None

@AlexWaygoodAlexWaygoodDec 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR feels like it only does my least favourite thing about your other PR :// #113299 (comment)

erlend-aasland
erlend-aasland reviewed Dec 20, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py

global clinic
clinic = self
utils.clinic = self

@erlend-aaslanderlend-aaslandDec 20, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, putting a global from one file into another file is not a good idea.

@vstinner

vstinner commented Dec 20, 2023

Copy link
Copy Markdown
MemberAuthor

@erlend-aasland:

IMO, putting a global from one file into another file is not a good idea.

I don't have the bandwidth right now to move this global variable. Adding utils.clinic variable is a temporary solution until someone can spend time to work on it. I gave on my latest attempt to partially fix the issue since nobody was available to review my work: #110984

Apparently, it's a requirement for @AlexWaygood and @erlend-aasland so I prefer to close this PR for now.

@erlend-aaslanderlend-aasland mentioned this pull request Dec 20, 2023
Closed
@vstinner
vstinner deleted the libclinic_converters branch December 20, 2023 13:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland left review comments
@AlexWaygoodAlexWaygoodAlexWaygood left review comments

Assignees

No one assigned

Labels

awaiting core reviewskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@erlend-aasland@AlexWaygood