Uh oh!
There was an error while loading. Please reload this page.
GH-110109: pathlib ABCs: drop use of io.text_encoding() - #113417
Merged
Conversation
Do not use the locale-specific default encoding in `PathBase.read_text()` and `write_text()`. Locale settings shouldn't influence the operation of these base classes, which are intended mostly for implementing rich paths on *nonlocal* filesystems.
8 tasks
barneygale
commented
Dec 23, 2023
ContributorAuthor
Downstream |
methane
approved these changes
Dec 25, 2023
barneygale
commented
Dec 27, 2023
ContributorAuthor
Thank you for the review, @methane |
kulikjak pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…on#113417) Do not use the locale-specific default encoding in `PathBase.read_text()` and `write_text()`. Locale settings shouldn't influence the operation of these base classes, which are intended mostly for implementing rich paths on *nonlocal* filesystems.
aisk pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…on#113417) Do not use the locale-specific default encoding in `PathBase.read_text()` and `write_text()`. Locale settings shouldn't influence the operation of these base classes, which are intended mostly for implementing rich paths on *nonlocal* filesystems.
Glyphack pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…on#113417) Do not use the locale-specific default encoding in `PathBase.read_text()` and `write_text()`. Locale settings shouldn't influence the operation of these base classes, which are intended mostly for implementing rich paths on *nonlocal* filesystems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not use the locale-specific default encoding in
PathBase.read_text()andwrite_text(). Locale settings shouldn't influence the operation of these base classes, which are intended mostly for implementing rich paths on nonlocal filesystems.Also add a comment explaining the necessity of the
io.text_encoding()call inPath.read_text()andwrite_text()despite its presence inopen().