Uh oh!
There was an error while loading. Please reload this page.
gh-101100: Fix Sphinx warnings in library/cmd.rst - #113502
Conversation
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. I have only doubts about silencing sys.stdout.write and sys.stdin.readline. Maybe add references to sys.stdout and sys.stdin?
hugovk
commented
Dec 27, 2023
Sounds good, updated! |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
AlexWaygood
left a comment
There was a problem hiding this comment.
Nitpick: no need to link to the thing we're already reading (otherwise, this looks great!)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, @hugovk, I could not cleanly backport this to |
GH-113510 is a backport of this pull request to the 3.11 branch. |
GH-113511 is a backport of this pull request to the 3.12 branch. |
…honGH-113502) (cherry picked from commit 4acf825) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
#113510) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
#113511) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Fix 13 Sphinx warnings:
do_foo,complete_foo,help_baranddo_bar,do_forwardanddo_playbackare examples, silence with!do_help, let's add.. method:: Cmd.do_help(arg)so it can be linked tosys.stdout.writeandsys.stdin.readlinewith!. Or is there somewhere good to link to?cmdqueuewas missing the class ref, change to~Cmd.cmdqueue📚 Documentation preview 📚: https://cpython-previews--113502.org.readthedocs.build/