Skip to content

functools.partial docs: Use the more common spelling for "referenceable" - #113675

Merged
AlexWaygood merged 1 commit into
python:mainfrom
rodrigogiraoserrao:patch-2
Jan 3, 2024
Merged

functools.partial docs: Use the more common spelling for "referenceable"#113675
AlexWaygood merged 1 commit into
python:mainfrom
rodrigogiraoserrao:patch-2

Conversation

@rodrigogiraoserrao

@rodrigogiraoserraorodrigogiraoserrao commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

Fixes a typo in the last paragraph of the docs on partial objects, https://docs.python.org/3/library/functools.html#partial-objects


📚 Documentation preview 📚: https://cpython-previews--113675.org.readthedocs.build/

@Eclips4

Eclips4 commented Jan 3, 2024

Copy link
Copy Markdown
Member

Per https://en.wiktionary.org/wiki/referencable this doesn't looks as a typo.
cc @AlexWaygood as a english native speaker

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are acceptable spellings, but "referenceable" is the more common one, and does look more natural to my eyes. So I'm happy for this to go in :)

@AlexWaygoodAlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 3, 2024
@AlexWaygoodAlexWaygood changed the title Fix typo in docs about partial objectsfunctools.partial docs: Use the more common spelling for "referenceable"Jan 3, 2024
@AlexWaygood
AlexWaygood merged commit 4de468c into python:mainJan 3, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @rodrigogiraoserrao for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-app

Copy link
Copy Markdown

GH-113677 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Jan 3, 2024
@bedevere-app

Copy link
Copy Markdown

GH-113678 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Jan 3, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 3, 2024
…able" (pythonGH-113675)
(cherry picked from commit 4de468c)
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 3, 2024
…able" (pythonGH-113675)
(cherry picked from commit 4de468c)
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
@Eclips4

Eclips4 commented Jan 3, 2024

Copy link
Copy Markdown
Member

Both are acceptable spellings, but "referenceable" is the more common one, and does look more natural to my eyes. So I'm happy for this to go in :)

We also have at least three similar situations: c-api/weakref.rst (38 and 50 lines) and newtypes.rst (548 line). Should we fix it?

AlexWaygood pushed a commit that referenced this pull request Jan 3, 2024
…ferenceable" (GH-113675) (#113677)
`functools.partial` docs: Use the more common spelling for "referenceable" (GH-113675)
(cherry picked from commit 4de468c)
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
AlexWaygood pushed a commit that referenced this pull request Jan 3, 2024
…ferenceable" (GH-113675) (#113678)
`functools.partial` docs: Use the more common spelling for "referenceable" (GH-113675)
(cherry picked from commit 4de468c)
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
@AlexWaygood

Copy link
Copy Markdown
Member

We also have at least three similar situations: c-api/weakref.rst (38 and 50 lines) and newtypes.rst (548 line). Should we fix it?

If you make a PR, I'll probably merge it -- but also, I wouldn't say it's a priority, since both are acceptable spellings :)

@rodrigogiraoserrao

Copy link
Copy Markdown
ContributorAuthor

Merriam-Webster and the Oxford Learner's Dictionary seem to disagree, https://www.merriam-webster.com/thesaurus/referencable & https://www.oxfordlearnersdictionaries.com/spellcheck/english/?q=referencable

I won't push more than this, though, as I'm not a native speaker.

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rodrigogiraoserrao@Eclips4@AlexWaygood