Uh oh!
There was an error while loading. Please reload this page.
gh-113692: skip a test if multiprocessing isn't available. - #113704
Conversation
bedevere-bot
commented
Jan 4, 2024
bedevere-bot
commented
Jan 5, 2024
hauntsaninja
left a comment
There was a problem hiding this comment.
Looks good!
(should we set required_on to at least one platform as typo protection?)
vsajip
commented
Jan 7, 2024
Thanks. Do you think that's needed for this specific issue? It seems a simple enough change. Not sure what you mean by typo protection. |
brettcannon
commented
Jan 8, 2024
I think @hauntsaninja is suggesting we require this pass on some platform to avoid a typo in the name of the module being imported since there's no error checking the module name is legitimate (although could that check be added thanks to @vsajip I added the backport label as I think this needs to land in 3.12 as well. |
Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
…honGH-113704) (cherry picked from commit 842b738) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
GH-113844 is a backport of this pull request to the 3.12 branch. |
Yup, that's what I meant :-) Looks like sys.stdlib_module_names won't do the trick, it doesn't include things like |
vsajip
commented
Jan 9, 2024
Perhaps |
Yeah, I took Brett's suggestion to mean we add a check against |
test_logging's test_111615 fails under WASI #113692