Skip to content

gh-113937 Fix failures in type cache tests due to re-running - #113953

Merged
Fidget-Spinner merged 2 commits into
python:mainfrom
lazorchakp:gh-113937-fix-type-cache-test-failures
Jan 12, 2024
Merged

gh-113937 Fix failures in type cache tests due to re-running#113953
Fidget-Spinner merged 2 commits into
python:mainfrom
lazorchakp:gh-113937-fix-type-cache-test-failures

Conversation

@lazorchakp

@lazorchakplazorchakp commented Jan 11, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This addresses test failures in test_type_cache arising from re-running the same tests multiple times. There are no source code changes. New behavior in test_type_cache:

  • skip tests if a valid version tag cannot be initially assigned
  • only check whether a function has / has not been specialized after calling it several times

To test these changes, I ran the following tests:

  • ./python.exe -m test test_type_cache
  • ./python.exe -m test test_type_cache --forever (killed manually after 5 minutes)
  • ./python.exe -m test test_type_cache -R 3:3

I specifically did not add a news entry, but will happily do so if anyone thinks it's appropriate.

@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label Jan 11, 2024
@bedevere-appbedevere-appBot mentioned this pull request Jan 11, 2024
Closed
Fidget-Spinner
Fidget-Spinner approved these changes Jan 11, 2024
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right. Thanks for the quick fix! We usually don't need a news entry for tests unless its significant or went out in a released Python version.

@lazorchakp

lazorchakp commented Jan 11, 2024

Copy link
Copy Markdown
ContributorAuthor

Sounds good. Hopefully this is the only issue here. I'm considering waiting until tomorrow to perform the backports just in case another bug comes up - I've read through https://devguide.python.org/testing/run-write-tests/ and think I have everything covered, but I'm still somewhat pessimistic

@lazorchakp
lazorchakp marked this pull request as ready for review January 11, 2024 19:15
@Fidget-Spinner

Fidget-Spinner commented Jan 12, 2024

Copy link
Copy Markdown
Member

I could test with buildbots to see if it would pass on main, but main buildbots seem to be currently failing so I won't do that.

@Fidget-Spinner
Fidget-Spinner merged commit e58334e into python:mainJan 12, 2024
@markshannon

markshannon commented Jan 12, 2024•
edited
Loading

Copy link
Copy Markdown
Member

test_type_cache seems to be failing for pretty much all the refleak buildbots.
#113944

@Fidget-Spinner

Fidget-Spinner commented Jan 12, 2024

Copy link
Copy Markdown
Member

I'll investigate later.

@Fidget-Spinner

Fidget-Spinner commented Jan 12, 2024

Copy link
Copy Markdown
Member

Just to clarify: this PR fixed the buildbots. The other PR #113937 was the one that introduced the leaks.

@lazorchakp
lazorchakp deleted the gh-113937-fix-type-cache-test-failures branch January 12, 2024 16:04
@pnachtpnacht mentioned this pull request Jan 12, 2024
Closed
@lazorchakp

lazorchakp commented Jan 12, 2024

Copy link
Copy Markdown
ContributorAuthor

From what I can tell, after this PR there are no longer any issues related to test_type_cache in the buildbots (please correct me if I'm wrong and I'll address them).

If everything still looks good next week, I'll backport #113558 + this PR to 3.11 and 3.12.

lazorchakp added a commit to lazorchakp/cpython that referenced this pull request Jan 17, 2024
@lazorchakp
pythongh-113937Fix failures in type cache tests due to re-running (p…
a03c3ad
…ythonGH-113953)
@lazorchakplazorchakp mentioned this pull request Jan 17, 2024
Merged
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@lazorchakp@kulikjak
pythongh-113937Fix failures in type cache tests due to re-running (p…
3be5a17
…ythonGH-113953)
lazorchakp added a commit to lazorchakp/cpython that referenced this pull request Feb 5, 2024
@lazorchakp
pythongh-113937Fix failures in type cache tests due to re-running (p…
c0ba6b4
…ythonGH-113953)
@lazorchakplazorchakp mentioned this pull request Feb 5, 2024
Merged
Fidget-Spinner pushed a commit that referenced this pull request Feb 6, 2024
@lazorchakp
[3.11]gh-89811: Check for valid tp_version_tag in specializer (GH-11…
a113124
…5045)
* gh-89811: Check for valid tp_version_tag in specializer (GH-113558)
* gh-113937 Fix failures in type cache tests due to re-running (GH-113953)
* Update backported code for 3.11 specifically
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@lazorchakp@aisk
pythongh-113937Fix failures in type cache tests due to re-running (p…
4029459
…ythonGH-113953)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@lazorchakp@Glyphack
pythongh-113937Fix failures in type cache tests due to re-running (p…
7846f12
…ythonGH-113953)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes
@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstraJelleZijlstra is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lazorchakp@Fidget-Spinner@markshannon