Uh oh!
There was an error while loading. Please reload this page.
gh-111803: Use more reasonable nesting in test_plistlib's test_deep_nesting - #114020
Closed
ronaldoussoren wants to merge 1 commit into
Closed
gh-111803: Use more reasonable nesting in test_plistlib's test_deep_nesting#114020ronaldoussoren wants to merge 1 commit into
ronaldoussoren wants to merge 1 commit into
Conversation
This adjust the nesting levels used by the test_deep_nesting because the previous levels consistently hit the recursion limit and ended up not testing anything. Adjusting the level is reasonable because the tested nesting levels should still be significantly larger than those seen in real world plist files. The test also no longer ignores recursion errors.
ronaldoussoren
commented
Jan 13, 2024
ContributorAuthor
#114024 is a better fix for the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjust the nesting levels used by the test_deep_nesting because the previous levels consistently hit the recursion limit and ended up not testing anything.
Adjusting the level is reasonable because the tested nesting levels should still be significantly larger than those seen in real world plist files.
The test also no longer ignores recursion errors.
test_deep_nestingfromtest_plistlibtriggers an exhausted stack protection in a debug build under WASI #111803