Skip to content

[3.12] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) - #114173

Merged
iritkatriel merged 2 commits into
python:3.12from
perrinjerome:backport-04fabe2-3.12
Jan 21, 2024
Merged

[3.12] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359)#114173
iritkatriel merged 2 commits into
python:3.12from
perrinjerome:backport-04fabe2-3.12

Conversation

@perrinjerome

@perrinjeromeperrinjerome commented Jan 17, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 04fabe2)

Adjusted for 3.12, because exception printing also happens in C code.

@bedevere-appbedevere-appBot mentioned this pull request Jan 17, 2024
Closed
@perrinjeromeperrinjerome changed the title gh-113358: Fix rendering tracebacks with exceptions with a broken __g…etattr__ (GH-113359)gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359)Jan 17, 2024
@AlexWaygoodAlexWaygood changed the title gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359)[3.12] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359)Jan 17, 2024
@bedevere-appbedevere-appBot mentioned this pull request Jan 17, 2024
Merged
@perrinjerome@iritkatriel
[3.12]pythongh-113358: Fix rendering tracebacks with exceptions with…
3588252
… a broken __getattr__ (pythonGH-113359)
(cherry picked from commit 04fabe2)
Co-authored-by: Jérome Perrin <perrinjerome@gmail.com>
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@perrinjerome
perrinjerome marked this pull request as ready for review January 20, 2024 05:35
@perrinjerome

perrinjerome commented Jan 20, 2024

Copy link
Copy Markdown
ContributorAuthor

@iritkatriel this is for 3.12 ,is it better to use PyErr_GetRaisedException as mentionned on
https://github.com/python/cpython/pull/114118/files#r1455635968 or to keep the same code as for 3.11 ? This version uses the same code as 3.11

@iritkatrieliritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 20, 2024
@bedevere-bot

bedevere-bot commented Jan 20, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 3588252 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 20, 2024
@iritkatriel

iritkatriel commented Jan 20, 2024

Copy link
Copy Markdown
Member

@iritkatriel this is for 3.12 ,is it better to use PyErr_GetRaisedException as mentionned on https://github.com/python/cpython/pull/114118/files#r1455635968 or to keep the same code as for 3.11 ? This version uses the same code as 3.11

We can leave it the same. Thanks.

iritkatriel
iritkatriel reviewed Jan 20, 2024
View reviewed changes
Comment threadPython/pythonrun.c
@perrinjeromeperrinjerome mentioned this pull request Jan 21, 2024
Merged
@iritkatriel
iritkatriel merged commit 00e8c9c into python:3.12Jan 21, 2024
@Eclips4Eclips4 mentioned this pull request Jan 21, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@perrinjerome@bedevere-bot@iritkatriel