gh-112075: Adapt more dict methods to Argument Clinic by DinoV · Pull Request #114256 · python/cpython

DinoV · 2024-01-18T18:03:36Z

Uses argument clinic for the remaining dict methods which aren't using it yet. This will allow to use argument clinic's @critical_section consistently where it's appropriate.

Mostly straight forward, the most dramatic thing is that some of the argument clinic names overlap with existing names. Those existing names are just wrapped in public dict API so the functionality just moves into the public API.

Issue: Make dict objects thread-safe in --disable-gil builds #112075

erlend-aasland · 2024-01-23T20:26:12Z

Sorry to add remarks on the already amended docstrings, but let's avoid the CI churn of addressing this in another PR :)

erlend-aasland

LGTM with last round of suggestions applied.

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

DinoV · 2024-01-23T20:59:10Z

Thanks, I've appied them all!

erlend-aasland · 2024-01-23T21:03:25Z

Thanks, I've appied them all!

Regen clinic ;)

erlend-aasland · 2024-01-23T22:22:05Z

@DinoV, next time, can you please clean up the commit message before merging?

DinoV · 2024-01-23T22:23:26Z

@DinoV, next time, can you please clean up the commit message before merging?

Ahh yes, sorry! :(

…14256) * Move more dict objects to argument clinic * Improve doc strings * More doc string improvements * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> --------- Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

bedevere-appBot mentioned this pull request Jan 18, 2024
Make dict objects thread-safe in --disable-gil builds #112075
Closed

DinoV added topic-free-threading skip news labels Jan 18, 2024

DinoV force-pushed the nogil_dict branch from 011c100 to 0cef393Compare January 18, 2024 18:51

DinoV marked this pull request as ready for review January 18, 2024 20:11

DinoV requested review from markshannon and methane as code owners January 18, 2024 20:11

bedevere-appBot added the awaiting core review label Jan 18, 2024

methane reviewed Jan 19, 2024
View reviewed changes

Comment threadObjects/dictobject.c Outdated
Comment threadObjects/dictobject.c Outdated
Comment threadObjects/dictobject.c Outdated
Comment threadObjects/dictobject.c Outdated
Comment threadObjects/dictobject.c Outdated
Comment threadObjects/dictobject.c Outdated

serhiy-storchaka requested a review from rhettinger January 19, 2024 12:35

DinoV force-pushed the nogil_dict branch 2 times, most recently from 5e7a200 to 72a78e4Compare January 19, 2024 21:02

rhettinger removed their request for review January 19, 2024 21:28

methane reviewed Jan 23, 2024
View reviewed changes

Comment threadObjects/dictobject.c Outdated

methane reviewed Jan 23, 2024
View reviewed changes

Comment threadObjects/dictobject.c Outdated

methane reviewed Jan 23, 2024
View reviewed changes

Comment threadObjects/dictobject.c Outdated
Comment threadObjects/dictobject.c Outdated

DinoV added 2 commits January 23, 2024 10:39

Move more dict objects to argument clinic
9ec8bdc

Improve doc strings
68a5d6c

DinoV force-pushed the nogil_dict branch from 72a78e4 to 873dc27Compare January 23, 2024 18:39

More doc string improvements
e588a9c

DinoV force-pushed the nogil_dict branch from 873dc27 to e588a9cCompare January 23, 2024 18:45

erlend-aasland reviewed Jan 23, 2024
View reviewed changes

erlend-aasland changed the title ~~gh-112075: Move more dict objects to argument clinic in preparation for using argument clinic for more locking~~gh-112075: Adapt more dict methods to Argument ClinicJan 23, 2024

erlend-aasland approved these changes Jan 23, 2024
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting core review labels Jan 23, 2024

DinoVand others added 3 commits January 23, 2024 12:57

Update Objects/dictobject.c
6a32f7b
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Update Objects/dictobject.c
65abc0a
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Update Objects/dictobject.c
8629b17
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

DinoVand others added 4 commits January 23, 2024 12:58

Update Objects/dictobject.c
55ef739
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Update Objects/dictobject.c
278a995
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Update Objects/dictobject.c
ec39bfc
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Update Objects/dictobject.c
c6aede1
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Merge branch 'main' into nogil_dict
6614421

DinoV enabled auto-merge (squash) January 23, 2024 20:59

DinoV added 2 commits January 23, 2024 13:33

Merge branch '6614421'
12838d4

Regen clinic
50be41d

DinoV merged commit afe8f37 into python:mainJan 23, 2024

bedevere-appBot removed the awaiting merge label Jan 23, 2024

Uh oh!

Uh oh!

Conversation

DinoV commented Jan 18, 2024• edited by bedevere-app BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Jan 23, 2024

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

DinoV commented Jan 23, 2024

Uh oh!

erlend-aasland commented Jan 23, 2024

Uh oh!

erlend-aasland commented Jan 23, 2024

Uh oh!

DinoV commented Jan 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DinoV commented Jan 18, 2024•
edited by bedevere-app Bot
Loading