Uh oh!
There was an error while loading. Please reload this page.
gh-113884: Refactor queue.SimpleQueue to use a ring buffer to store items - #114259
Merged
erlend-aasland merged 9 commits intoJan 19, 2024
Merged
Conversation
Using a ring buffer instead of a Python list will simplify the process of making `queue.SimpleQueue` thread-safe in free-threaded builds. The ring buffer implementation has no places where critical sections may be released.
colesbury
approved these changes
Jan 18, 2024
colesbury
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
@erlend-aasland, would you be able to review this?
erlend-aasland
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing the refactoring first!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rhettinger
removed their request for review
January 19, 2024 04:12
mpage
commented
Jan 19, 2024
ContributorAuthor
@erlend-aasland - I think I've addressed all of your comments. Would you please take another look? |
erlend-aasland
enabled auto-merge (squash)
January 19, 2024 11:56
erlend-aasland
commented
Jan 19, 2024
Contributor
Thanks a lot, @mpage and @colesbury 🙏 |
kulikjak pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
… store items (python#114259) Use a ring buffer instead of a Python list in order to simplify the process of making queue.SimpleQueue thread-safe in free-threaded builds. The ring buffer implementation has no places where critical sections may be released.
aisk pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
… store items (python#114259) Use a ring buffer instead of a Python list in order to simplify the process of making queue.SimpleQueue thread-safe in free-threaded builds. The ring buffer implementation has no places where critical sections may be released.
Glyphack pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
… store items (python#114259) Use a ring buffer instead of a Python list in order to simplify the process of making queue.SimpleQueue thread-safe in free-threaded builds. The ring buffer implementation has no places where critical sections may be released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a ring buffer instead of a Python list will simplify the process of making
queue.SimpleQueuethread-safe in free-threaded builds. The ring buffer implementation has no places where critical sections may be released.--disable-gilbuilds #113884