Uh oh!
There was an error while loading. Please reload this page.
gh-114281: Remove incorrect type hints from asyncio.staggered - #114282
Merged
Conversation
sobolevn
requested review from
1st1, asvetlov, gvanrossum, kumaraditya303 and willingc
as code ownersJanuary 19, 2024 09:06
gvanrossum
left a comment
Member
There was a problem hiding this comment.
TBH, I don't want to maintain type annotations in stdlib modules unless we run mypy in CI. Maybe we should just remove these rather than try to fix them?
sobolevn
commented
Jan 20, 2024
MemberAuthor
Sure, typeshed has the correct version anyway 👍 |
AA-Turner
approved these changes
Jan 20, 2024
Uh oh!
There was an error while loading. Please reload this page.
…5JQe4.rst Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
asyncio/staggered.pyasyncio.staggeredgvanrossum
approved these changes
Jan 20, 2024
kulikjak pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…python#114282) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
aisk pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…python#114282) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Glyphack pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…python#114282) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyncio.staggeredhas incorrect type hints #114281