Uh oh!
There was an error while loading. Please reload this page.
gh-114314: Move types to ctypes_state - #114316
Closed
vstinner wants to merge 3 commits into
Closed
Conversation
Move types to the ctypes_state structure: * PyCArray_Type * PyCData_Type * PyCFuncPtr_Type * PyCPointer_Type * Simple_Type The following macros get an additional state parameter: * ArrayObject_Check() * CDataObject_Check() * CDataObject_CheckExact() * PointerObject_Check() * PyCFuncPtrObject_Check() The following function gets an additional state parameter: * _PyCData_set() Co-Authored-By: neonene <53406459+neonene@users.noreply.github.com>
vstinner
commented
Jan 19, 2024
MemberAuthor
This change only prepares the code to convert static types to heap types. It doesn't change the behavior. It only moves references to types from global variables to the |
vstinner
commented
Jan 19, 2024
MemberAuthor
To keep this change as small as possible, I didn't change the following macros to add a new state parameter. These macros can be changed afterwards. |
vstinner
commented
Jan 19, 2024
MemberAuthor
neonene
commented
Jan 20, 2024
Contributor
PR #113857, which expects fewer follow-up PRs, can be closed after this is landed. |
vstinner
commented
Jan 22, 2024
MemberAuthor
I merged #113857 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move types to the ctypes_state structure:
The following macros get an additional state parameter:
The following function gets an additional state parameter: