Uh oh!
There was an error while loading. Please reload this page.
[3.12] gh-80931: Skip some socket tests while hunting for refleaks on macOS (GH-114057) - #114381
Closed
miss-islington wants to merge 1 commit into
Closed
[3.12] gh-80931: Skip some socket tests while hunting for refleaks on macOS (GH-114057)#114381miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
…macOS (pythonGH-114057) Some socket tests related to sending file descriptors cause a file descriptor leak on macOS, all of them tests that send one or more descriptors than cannot be received on the read end. This appears to be a platform bug. This PR skips those tests when doing a refleak test run to avoid hiding other problems. (cherry picked from commit 5adff3f) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
This was referenced Jan 21, 2024
gpshead
commented
Aug 9, 2024
Member
is this back port needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some socket tests related to sending file descriptors cause a file descriptor leak on macOS, all of them tests that send one or more descriptors than cannot be received on the read end. This appears to be a platform bug.
This PR skips those tests when doing a refleak test run to avoid hiding other problems.
(cherry picked from commit 5adff3f)
Co-authored-by: Ronald Oussoren ronaldoussoren@mac.com