Skip to content

importlib/_bootstrap.py: Reduce size of _List instances - #114747

Merged
brettcannon merged 1 commit into
python:mainfrom
Eclips4:reduce_list_size
Jan 30, 2024
Merged

importlib/_bootstrap.py: Reduce size of _List instances#114747
brettcannon merged 1 commit into
python:mainfrom
Eclips4:reduce_list_size

Conversation

@Eclips4

@Eclips4Eclips4 commented Jan 30, 2024

Copy link
Copy Markdown
Member

@Eclips4

Eclips4 commented Jan 30, 2024

Copy link
Copy Markdown
MemberAuthor

This change prevents us from creating __dict__ for each instance of _Lock type.

brettcannon
brettcannon approved these changes Jan 30, 2024
View reviewed changes
Comment threadLib/importlib/_bootstrap.py
@brettcannon
brettcannon merged commit 6de8aa3 into python:mainJan 30, 2024
@Eclips4
Eclips4 deleted the reduce_list_size branch January 30, 2024 20:17
@Eclips4

Eclips4 commented Jan 30, 2024

Copy link
Copy Markdown
MemberAuthor

Since the initial fix (#108497) was backported to 3.12 branch, maybe it's makes sense to backport this patch as well?
@brettcannon@Yhg1s

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@Eclips4@aisk
importlib/_bootstrap.py: Reduce size of_Listinstances (pyth…
d9157c3
…onGH-114747)
Reduce size of _List instances
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannonbrettcannonbrettcannon approved these changes
@Yhg1sYhg1sAwaiting requested review from Yhg1s

Assignees

No one assigned

Labels

skip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Eclips4@brettcannon