Uh oh!
There was an error while loading. Please reload this page.
gh-67230: Add versionadded notes for QUOTE_NOTNULL and QUOTE_STRINGS - #114816
Merged
Conversation
@GPHemsley pointed out that with the recent changes in python#29469, two new data items failed to get `versionadded` notes.
merwok
approved these changes
Jan 31, 2024
Thanks @smontanaro for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 1, 2024
…RINGS (pythonGH-114816) As @GPHemsley pointed out, pythonGH-29469 omitted `versionadded` notes for the 2 new items. (cherry picked from commit 586057e) Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
GH-114840 is a backport of this pull request to the 3.12 branch. |
terryjreedy
commented
Feb 1, 2024
Member
In my view, a correction to a defective patch should be attached to the issue for the original patch (unless there is a new issue, which there is not here). Merging. |
terryjreedy pushed a commit
that referenced
this pull request
Feb 1, 2024
…TRINGS (GH-114816) (#114840) As @GPHemsley pointed out, GH-29469 omitted `versionadded` notes for the 2 new items. (cherry picked from commit 586057e) Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
smontanaro
commented
Feb 1, 2024
ContributorAuthor
Thanks. It didn't occur to me to amend a closed issue. |
aisk pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…RINGS (python#114816) As @GPHemsley pointed out, python#29469 omitted `versionadded` notes for the 2 new items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @GPHemsley pointed out, #29469 omitted
versionaddednotes for the 2 new items.📚 Documentation preview 📚: https://cpython-previews--114816.org.readthedocs.build/