Skip to content

gh-114875: Add getgrent as a prerequisite for building the grp module - #114876

Merged
erlend-aasland merged 3 commits into
python:mainfrom
mhsmith:grp-getgrent
Feb 2, 2024
Merged

gh-114875: Add getgrent as a prerequisite for building the grp module#114876
erlend-aasland merged 3 commits into
python:mainfrom
mhsmith:grp-getgrent

Conversation

@mhsmith

@mhsmithmhsmith commented Feb 1, 2024•
edited
Loading

Copy link
Copy Markdown
Member

This allows the module to be correctly skipped on older versions of Android which don't have getgrent and related functions:

checking for getgrent... no
checking for getgrgid... yes
checking for getgrgid_r... no
[...]
checking for stdlib extension module grp... missing

@bedevere-appbedevere-appBot mentioned this pull request Feb 1, 2024
Closed
erlend-aasland
erlend-aasland reviewed Feb 1, 2024
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment threadMisc/NEWS.d/next/Build/2024-02-01-20-08-11.gh-issue-114875.x_2iZ9.rst Outdated
Comment threadconfigure.ac Outdated
mhsmithand others added 2 commits February 2, 2024 19:43
@mhsmith@erlend-aasland
Apply suggestions from code review
bb1fe58
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@mhsmith
Autoreconf
9cf79f3
@mhsmith

mhsmith commented Feb 2, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks; suggestions all applied.

@erlend-aasland
erlend-aasland merged commit f35c7c0 into python:mainFeb 2, 2024
@erlend-aasland

erlend-aasland commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

Thanks again :)

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@mhsmith@erlend-aasland@aisk
pythongh-114875: Require getgrent for building the grp extension modu…
b5273ef
…le (python#114876)
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@mhsmith@erlend-aasland@fsc-eriker
pythongh-114875: Require getgrent for building the grp extension modu…
73b7e69
…le (python#114876)
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@mhsmith
mhsmith deleted the grp-getgrent branch February 16, 2024 21:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

grp module attempts to build even if getgrent family of functions are unavailable

2 participants

@mhsmith@erlend-aasland