Skip to content

gh-76763: Make chr() always raising ValueError for out-of-range values - #114882

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:chr-overflow
Feb 10, 2024
Merged

gh-76763: Make chr() always raising ValueError for out-of-range values#114882
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:chr-overflow

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Feb 1, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Previously it raised OverflowError for very large or very small values.

@serhiy-storchaka
pythongh-76763: Make chr() always raising ValueError for out-of-range…
d415909
… values
Previously it raised OverflowError for very large or very small values.
@bedevere-appbedevere-appBot mentioned this pull request Feb 1, 2024
Closed
eendebakpt
eendebakpt reviewed Feb 1, 2024
View reviewed changes
Comment threadMisc/NEWS.d/next/Core and Builtins/2024-02-01-23-43-49.gh-issue-76763.o_2J6i.rst Outdated
@ericsnowcurrently
ericsnowcurrently removed their request for review February 2, 2024 00:26
@serhiy-storchaka@eendebakpt
Update Misc/NEWS.d/next/Core and Builtins/2024-02-01-23-43-49.gh-issu…
a30ab10
…e-76763.o_2J6i.rst
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
@serhiy-storchaka

serhiy-storchaka commented Feb 2, 2024

Copy link
Copy Markdown
MemberAuthor

@vstinner, it has the same effect to your #5218, but without raising and catching an OverflowError.

mdickinson
mdickinson approved these changes Feb 10, 2024
View reviewed changes

@mdickinsonmdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka
serhiy-storchaka merged commit e2c4038 into python:mainFeb 10, 2024
@serhiy-storchaka
serhiy-storchaka deleted the chr-overflow branch February 10, 2024 10:21
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@serhiy-storchaka@fsc-eriker
pythongh-76763: Make chr() always raising ValueError for out-of-range…
f7d2872
… values (pythonGH-114882)
Previously it raised OverflowError for very large or very small values.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eendebakpteendebakpteendebakpt left review comments
@vstinnervstinnerAwaiting requested review from vstinner
+1 more reviewer
@mdickinsonmdickinsonmdickinson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka@mdickinson@eendebakpt