Skip to content

gh-111968: Refactor _PyXXX_Fini to integrate with _PyObject_ClearFreeLists - #114899

Merged
corona10 merged 14 commits into
python:mainfrom
corona10:gh-111968-fini
Feb 10, 2024
Merged

gh-111968: Refactor _PyXXX_Fini to integrate with _PyObject_ClearFreeLists#114899
corona10 merged 14 commits into
python:mainfrom
corona10:gh-111968-fini

Conversation

@corona10

@corona10corona10 commented Feb 2, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Feb 2, 2024
Closed
@corona10corona10 changed the title gh-111968: Refactor _PyXXX_Fini to follow Eric's suggestiongh-111968: Refactor _PyXXX_Fini to use _PyObject_ClearFreeListsFeb 2, 2024
@corona10

corona10 commented Feb 2, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Addressed by @ericsnowcurrently 's and @colesbury 's review from #111968 (comment)

@corona10corona10 changed the title gh-111968: Refactor _PyXXX_Fini to use _PyObject_ClearFreeListsgh-111968: Refactor _PyXXX_Fini to integrate with _PyObject_ClearFreeListsFeb 2, 2024
@corona10
corona10 marked this pull request as ready for review February 2, 2024 11:43
colesbury
colesbury reviewed Feb 2, 2024
View reviewed changes

@colesburycolesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although I'd probably name PySlice_ClearCache like the other freelist clearing functions for consistency.

Comment threadInclude/internal/pycore_gc.h Outdated
ericsnowcurrently
ericsnowcurrently requested changes Feb 2, 2024
View reviewed changes

@ericsnowcurrentlyericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. It mostly looks okay to me. There are just a few small things I'd like you to consider.

Comment threadPython/pystate.c Outdated
Comment threadPython/pystate.c Outdated
Comment threadInclude/internal/pycore_gc.h Outdated
@bedevere-app

bedevere-appBot commented Feb 2, 2024

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be put in the comfy chair!

corona10
corona10 commented Feb 3, 2024
View reviewed changes
Comment threadInclude/internal/pycore_freelist.h
struct _Py_object_stack_state object_stacks;
} _PyFreeListState;

extern void _PyObject_ClearFreeLists(_PyFreeListState *state, int is_finalization);

@corona10corona10Feb 3, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this API is not a domain-specific API, I located all ClearFreeList API into here :)

@corona10corona10 changed the title gh-111968: Refactor _PyXXX_Fini to integrate with _PyObject_ClearFreeLists[WIP] gh-111968: Refactor _PyXXX_Fini to integrate with _PyObject_ClearFreeListsFeb 3, 2024
@corona10corona10 changed the title [WIP] gh-111968: Refactor _PyXXX_Fini to integrate with _PyObject_ClearFreeListsgh-111968: Refactor _PyXXX_Fini to integrate with _PyObject_ClearFreeListsFeb 3, 2024
@corona10

corona10 commented Feb 3, 2024

Copy link
Copy Markdown
MemberAuthor

I have made the requested changes; please review again

@corona10

corona10 commented Feb 3, 2024

Copy link
Copy Markdown
MemberAuthor

As I commented before, we need some header cleanup, but I will do it as a separate PR since it affected a lot of codes, including bytecodes.c

@corona10

corona10 commented Feb 8, 2024

Copy link
Copy Markdown
MemberAuthor

@ericsnowcurrently gentle ping

ericsnowcurrently
ericsnowcurrently approved these changes Feb 9, 2024
View reviewed changes

@ericsnowcurrentlyericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10
corona10 enabled auto-merge (squash) February 10, 2024 00:42
@corona10
corona10 merged commit d4d5bae into python:mainFeb 10, 2024
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@corona10@fsc-eriker
pythongh-111968: Refactor _PyXXX_Fini to integrate with _PyObject_Cle…
6b88a97
…arFreeLists (pythongh-114899)
@corona10
corona10 deleted the gh-111968-fini branch February 15, 2024 01:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@colesburycolesburyAwaiting requested review from colesbury

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10@colesbury@ericsnowcurrently