Skip to content

gh-112087: Make list_{count, index, contains} to be thread-safe. - #114916

Merged
corona10 merged 4 commits into
python:mainfrom
corona10:gh-112087-fetch
Feb 6, 2024
Merged

gh-112087: Make list_{count, index, contains} to be thread-safe.#114916
corona10 merged 4 commits into
python:mainfrom
corona10:gh-112087-fetch

Conversation

@corona10

@corona10corona10 commented Feb 2, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Feb 2, 2024
Closed
4 tasks
@corona10

corona10 commented Feb 2, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Once the #114843 is merged, I will migrate APIs that both atomic operations and PyList_GetItemRef is needed.

@corona10
corona10 marked this pull request as ready for review February 2, 2024 15:42
colesbury
colesbury reviewed Feb 2, 2024
View reviewed changes
Comment threadObjects/listobject.c Outdated
colesbury
colesbury reviewed Feb 5, 2024
View reviewed changes

@colesburycolesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me other than the naming of _PyList_GetItemRef.

Comment threadObjects/listobject.c Outdated
@corona10corona10 mentioned this pull request Feb 6, 2024
Merged
colesbury
colesbury approved these changes Feb 6, 2024
View reviewed changes

@colesburycolesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadObjects/listobject.c Outdated
@corona10
corona10 enabled auto-merge (squash) February 6, 2024 16:01
@corona10
corona10 merged commit f7a22a7 into python:mainFeb 6, 2024
@corona10
corona10 deleted the gh-112087-fetch branch February 7, 2024 06:50
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@corona10@fsc-eriker
pythongh-112087: Make list_{count, index, contains} to be thread-safe. (
6280734
pythongh-114916)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes
@DinoVDinoVAwaiting requested review from DinoV

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@corona10@colesbury