Skip to content

gh-111968: Rename freelist related struct names to Eric's suggestion - #115329

Merged
corona10 merged 9 commits into
python:mainfrom
corona10:gh-111968-struct
Feb 14, 2024
Merged

gh-111968: Rename freelist related struct names to Eric's suggestion#115329
corona10 merged 9 commits into
python:mainfrom
corona10:gh-111968-struct

Conversation

@corona10

@corona10corona10 commented Feb 12, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Feb 12, 2024
Closed
@corona10

corona10 commented Feb 12, 2024

Copy link
Copy Markdown
MemberAuthor

#111968 (comment)

split struct _Py_dictkeys_freelist out of struct _Py_dict_freelist

Only one section is left :)

colesbury
colesbury reviewed Feb 12, 2024
View reviewed changes
Comment threadInclude/internal/pycore_freelist.h Outdated
Comment threadInclude/internal/pycore_tstate.h Outdated
@corona10

corona10 commented Feb 13, 2024

Copy link
Copy Markdown
MemberAuthor

CI failure is unrelated to this PR: see #115383

ericsnowcurrently
ericsnowcurrently approved these changes Feb 13, 2024
View reviewed changes

@ericsnowcurrentlyericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

colesbury
colesbury approved these changes Feb 13, 2024
View reviewed changes

@colesburycolesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@corona10
corona10 enabled auto-merge (squash) February 14, 2024 00:12
@corona10
corona10 merged commit f15795c into python:mainFeb 14, 2024
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@corona10@fsc-eriker
pythongh-111968: Rename freelist related struct names to Eric's sugge…
879a8d8
…stion (pythongh-115329)
@colesburycolesbury mentioned this pull request Feb 14, 2024
Closed
@corona10
corona10 deleted the gh-111968-struct branch February 14, 2024 17:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes
@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@methanemethaneAwaiting requested review from methanemethane is a code owner

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10@colesbury@ericsnowcurrently