Uh oh!
There was an error while loading. Please reload this page.
gh-115490: Work around test.support.interpreters.channels not handling unloading - #115515
Conversation
…, which regrtest does when running tests sequentially, by explicitly skipping the unloading of test.support.interpreters and its submodules. This can be rolled back once test.support.interpreters.channels supports unloading, if we are keeping sequential runs in the same process around.
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
@ericsnowcurrently: test_interpreters should do something about that in a tearDownModule() function, or find a workaround, rather than having to use such hack in regrtest :-(
I approve this PR to unblock Python 3.13 alpha4 release.
vstinner
commented
Feb 15, 2024
@ericsnowcurrently: Is Python 3.12 affected? |
Yhg1s
commented
Feb 15, 2024
No. test_interpreters.test_channels doesn't exist in 3.12, and running test_interpreters twice in the same process doesn't show any issues: |
encukou
commented
Feb 15, 2024
For the record, that fix is here: #115493 |
vstinner
commented
Feb 15, 2024
Thanks for the confirmation. |
…ls not handling unloading (python#115515)" This reverts commit b0e5c35.
Work around test.support.interpreters.channels not handling unloading, which regrtest does when running tests sequentially, by explicitly skipping the unloads of test.support.interpreters and its submodules.
This can be rolled back once test.support.interpreters.channels supports unloading, if we are keeping sequential runs in the same process around.