Uh oh!
There was an error while loading. Please reload this page.
gh-115480: Type / constant propagation for float binary uops - #115550
Merged
Fidget-Spinner merged 4 commits intoFeb 16, 2024
Conversation
ContributorAuthor
@Fidget-Spinner - opening this as a draft because I still have a few questions and it's waiting on some code from #115507.
|
lazorchakp
commented
Feb 16, 2024
ContributorAuthor
Also, I'll be on vacation until Tuesday and may be slow to respond. Please feel free to use / modify this code however you see fit if you're waiting on it |
Fidget-Spinner
commented
Feb 16, 2024
Member
Nice work! This is pretty close, I will just push some changes since you're on holiday. Some points for possible consideration are that the tests should test for the float guard being eliminated as well. |
Fidget-Spinner
approved these changes
Feb 16, 2024
lazorchakp
commented
Feb 20, 2024
ContributorAuthor
Thanks for finalizing and merging this 🎉 |
32 tasks
woodruffw pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…ythonGH-115550) Co-authored-by: Ken Jin <kenjin@python.org>
diegorusso pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ythonGH-115550) Co-authored-by: Ken Jin <kenjin@python.org>
LukasWoodtli pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
…ythonGH-115550) Co-authored-by: Ken Jin <kenjin@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
BINARY_OP#115480