Uh oh!
There was an error while loading. Please reload this page.
gh-112997: Don't log arguments in asyncio unless debugging - #115667
Conversation
Nothing else in Python generally logs the contents of variables, so this can be very unexpected for developers and could leak sensitive information in to terminals and log files.
gvanrossum
left a comment
There was a problem hiding this comment.
What about the calls to some of the modified functions in base_futures.py and futures.py?
| Special case for a single parameter: ('hello',) is formatted as ('hello'). | ||
| """ | ||
| # Avoid printing sensitive argument contents unless debugging |
There was a problem hiding this comment.
This behavior should be mentioned in the docstring, not just in a comment.
Uh oh!
There was an error while loading. Please reload this page.
CendioOssman
commented
Feb 27, 2024
There were no arguments included in the call in I can't see any calls for this in |
So that this information is more readily available.
gvanrossum
commented
Feb 28, 2024
It's a fair cop.
I was thinking of this: ifself._loop.get_debug():
self._source_traceback=format_helpers.extract_stack(
sys._getframe(1))but since that's already wrapped in I'm happy with this now, so I'll merge. Congrats! |
…hon#115667) Nothing else in Python generally logs the contents of variables, so this can be very unexpected for developers and could leak sensitive information in to terminals and log files.
…hon#115667) Nothing else in Python generally logs the contents of variables, so this can be very unexpected for developers and could leak sensitive information in to terminals and log files.
…hon#115667) Nothing else in Python generally logs the contents of variables, so this can be very unexpected for developers and could leak sensitive information in to terminals and log files.
…hon#115667) Nothing else in Python generally logs the contents of variables, so this can be very unexpected for developers and could leak sensitive information in to terminals and log files.
Nothing else in Python generally logs the contents of variables, so this can be very unexpected for developers and could leak sensitive information in to terminals and log files.