Skip to content

gh-115773: Add tests to exercise the _Py_DebugOffsets structure - #115774

Merged
pablogsal merged 8 commits into
python:mainfrom
pablogsal:external_inspection
Feb 28, 2024
Merged

gh-115773: Add tests to exercise the _Py_DebugOffsets structure#115774
pablogsal merged 8 commits into
python:mainfrom
pablogsal:external_inspection

Conversation

@pablogsal

@pablogsalpablogsal commented Feb 21, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@pablogsalpablogsal changed the title bpo-115773: Add tests to exercise the _Py_DebugOffsets structuregh-115773: Add tests to exercise the _Py_DebugOffsets structureFeb 21, 2024
@bedevere-appbedevere-appBot mentioned this pull request Feb 21, 2024
Closed
@pablogsal
pablogsalforce-pushed the external_inspection branch 3 times, most recently from 7e477c9 to 3583be6CompareFebruary 21, 2024 17:18
@pablogsal
pablogsal requested a review from ambvFebruary 21, 2024 17:19
@pablogsal
pablogsalforce-pushed the external_inspection branch 4 times, most recently from 4ced7ae to 53d4d57CompareFebruary 21, 2024 20:12
pablogsal
pablogsal commented Feb 21, 2024
View reviewed changes
Comment threadModules/_testexternalinspection.c Outdated
@pablogsal
pablogsal marked this pull request as draft February 21, 2024 20:15
erlend-aasland
erlend-aasland reviewed Feb 21, 2024
View reviewed changes
Comment threadModules/_testexternalinspection.c
@pablogsal
pablogsalforce-pushed the external_inspection branch 2 times, most recently from fdb96bf to 0de2132CompareFebruary 21, 2024 22:06
@pablogsal
pablogsal marked this pull request as ready for review February 21, 2024 23:28
pablogsal
pablogsal commented Feb 21, 2024
View reviewed changes
Comment threadModules/_testexternalinspection.c Outdated
@pablogsalpablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@pablogsalpablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@pablogsalpablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@bedevere-bot

bedevere-bot commented Feb 23, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit a4ebf4e 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 23, 2024
@pablogsal

pablogsal commented Feb 23, 2024

Copy link
Copy Markdown
MemberAuthor

@erlend-aasland can you take a look? I think I have addressed all of the weird 32 bit failures

@erlend-aasland

erlend-aasland commented Feb 23, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

I'll take a look tonight by sunday!

erlend-aasland
erlend-aasland reviewed Feb 26, 2024
View reviewed changes
Comment threadModules/_testexternalinspection.c Outdated
Comment threadModules/_testexternalinspection.c Outdated
Comment threadInclude/internal/pycore_runtime.h
Comment threadModules/_testexternalinspection.c Outdated
Comment threadModules/_testexternalinspection.c Outdated
Comment threadModules/_testexternalinspection.c
Comment threadModules/_testexternalinspection.c Outdated
Comment threadModules/_testexternalinspection.c
Comment threadModules/_testexternalinspection.c Outdated
Comment threadModules/_testexternalinspection.c Outdated
pablogsal
pablogsal commented Feb 26, 2024
View reviewed changes
Comment threadModules/_testexternalinspection.c Outdated
@pablogsal@erlend-aasland
Apply suggestions from code review
d3af59d
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
pablogsal
pablogsal commented Feb 26, 2024
View reviewed changes
Comment threadModules/_testexternalinspection.c Outdated
erlend-aasland
erlend-aasland approved these changes Feb 27, 2024
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pablogsalpablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 27, 2024
@bedevere-bot

bedevere-bot commented Feb 27, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 55bf6ac 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 27, 2024
@pablogsal
pablogsal merged commit 1752b51 into python:mainFeb 28, 2024
@pablogsal
pablogsal deleted the external_inspection branch February 28, 2024 10:17
@gvanrossum

gvanrossum commented Feb 28, 2024

Copy link
Copy Markdown
Member

Did this break some JIT builds? See #116062 (comment)

@gvanrossumgvanrossum mentioned this pull request Feb 28, 2024
Closed
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@pablogsal@woodruffw
pythongh-115773: Add tests to exercise the _Py_DebugOffsets structure (…
3b13c01
…python#115774)
@freakboy3742freakboy3742 mentioned this pull request Mar 6, 2024
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@pablogsal@adorilson
pythongh-115773: Add tests to exercise the _Py_DebugOffsets structure (…
5bd1262
…python#115774)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@pablogsal@diegorusso
pythongh-115773: Add tests to exercise the _Py_DebugOffsets structure (…
d17f201
…python#115774)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronaldoussorenronaldoussorenronaldoussoren left review comments
@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner
@corona10corona10Awaiting requested review from corona10corona10 is a code owner
@ambvambvAwaiting requested review from ambv

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal@bedevere-bot@erlend-aasland@gvanrossum@ronaldoussoren