Uh oh!
There was an error while loading. Please reload this page.
gh-115765: Don't use deprecated AC_EGREP_* macros in configure.ac - #115791
gh-115765: Don't use deprecated AC_EGREP_* macros in configure.ac#115791erlend-aasland wants to merge 10 commits into
Conversation
erlend-aasland
commented
Feb 21, 2024
@mhsmith, would you like to review this? |
erlend-aasland
commented
Feb 22, 2024
@corona10, feel free to take a look at this, if you have the time. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland
commented
Feb 22, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
erlend-aasland
commented
Feb 22, 2024
Found the culprit; typo on my end! ✅ |
erlend-aasland
commented
Feb 22, 2024
Now, there's one more thing we should add before landing this: support configure cache. |
erlend-aasland
commented
Feb 23, 2024
I'm not sure we want to automatically generate the cache variable name in this macro. The first argument would need heavy string modifications to end up as a usable identifier. Perhaps it is best to introduce a new param for the cache variable name. |
mhsmith
commented
Feb 23, 2024
Alternatively, all but one usage of PY_CHECK_CPP could be replaced with AX_CHECK_DEFINE, which has caching already built in. |
That's a good suggestion; I'll have a look in a day or two. UPDATE: Created alternative PR gh-116016. |
erlend-aasland
commented
Feb 27, 2024
For the glibc check; do we really need to worry about glibc < 2.1? |
mhsmith
commented
Feb 28, 2024
I agree, so #116016 looks like the way to go. |
erlend-aasland
commented
Feb 28, 2024
Superseded by #116016 |
See Autoconf docs: