gh-115808: Add ``is_none`` and ``is_not_none`` operators by ThexXTURBOXx · Pull Request #115814 · python/cpython

ThexXTURBOXx · 2024-02-22T10:10:51Z

This PR adds an is_none operator and an appropriate test.
I hope I did not forget to update/reference it anywhere else.

Fixes#115808

Issue: Add operator.is_none() #115808

ghost · 2024-02-22T10:10:54Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2024-02-22T10:10:58Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Eclips4 · 2024-02-22T10:22:06Z

Please, update the documentation for this module (Doc/library/operator.rst)

ThexXTURBOXx · 2024-02-22T10:22:22Z

@Eclips4 Thank you for the suggestion, updated it accordingly.

AlexWaygood

Thanks! In order for this to be merged, it would also need:

Documentation to be added in Doc/library/operator.rst
An entry in Doc/whatsnew/3.13.rst
An additional implementation written in C in https://github.com/python/cpython/blob/main/Modules/_operator.c

Here's the most recent PR that added a new function to the operator module, which you could use as a reference:

#27888

bedevere-app · 2024-02-22T11:42:12Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ThexXTURBOXx · 2024-02-22T12:34:56Z

I have made the requested changes; please review again

ThexXTURBOXx · 2024-02-22T14:47:39Z

I have made the requested changes; please review again

Requested changes were made

AlexWaygood

Thanks! This looks pretty good to me now. We'll need to wait a while to see if anybody voices any objections on the issue before we can consider merging this, though.

ThexXTURBOXx · 2024-02-22T15:18:25Z

No problem, take your time! And thank you very much for your valuable comments. They helped me shape my first PR here such that it fits your needs!

sobolevn

Thank you! I have several nitpicks :)

Eclips4

Looks very good for me. Good job @ThexXTURBOXx 👍

bateller

👍

ThexXTURBOXx · 2024-03-04T14:07:40Z

Rebased on main

ThexXTURBOXx · 2024-05-17T13:33:24Z

Rebased on main

ThexXTURBOXx · 2024-08-06T11:50:45Z

Rebased on main

ThexXTURBOXx · 2024-08-06T17:17:37Z

Thanks for the comments - fixed!

Eclips4 · 2024-08-06T17:32:47Z

Thanks for the comments - fixed!

Looks good, thanks.

However, what is about is_not_none#115808 (comment)?

I think it should be implemented, and I think that it is okay to do so in this PR, since these things are related.

cc @AlexWaygood @rhettinger

ThexXTURBOXx · 2024-08-06T18:17:39Z

However, what is about is_not_none #115808 (comment)?
I think it should be implemented, and I think that it is okay to do so in this PR, since these things are related.

You are right. I haven't seen this comment yet. I have also added an appropriate is_not_none function.

AA-Turner · 2024-08-07T15:08:33Z

If there are no outstanding concerns I'll look to merge this in the next few days (cc @Eclips4 if you have any final comments)

A

Eclips4

LGTM. Thanks @ThexXTURBOXx for your efforts!

ThexXTURBOXx · 2024-08-07T15:30:39Z

You're more than welcome, thanks for the reviews! :)

AA-Turner · 2024-08-10T19:16:39Z

Thanks all!

A

…ython#115814) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>

bedevere-appBot added the awaiting review label Feb 22, 2024

bedevere-appBot mentioned this pull request Feb 22, 2024
Add operator.is_none() #115808
Closed

Eclips4 requested a review from rhettinger February 22, 2024 10:17

Eclips4 reviewed Feb 22, 2024
View reviewed changes

Comment threadMisc/NEWS.d/next/Library/2024-02-22-10-12-59.gh-issue-115808.F2g2Ku.rst Outdated

AlexWaygood previously requested changes Feb 22, 2024
View reviewed changes

bedevere-appBot added awaiting changes and removed awaiting review labels Feb 22, 2024

AlexWaygood reviewed Feb 22, 2024
View reviewed changes

Comment threadDoc/library/operator.rst Outdated

AlexWaygood reviewed Feb 22, 2024
View reviewed changes

Comment threadDoc/library/operator.rst Outdated
Comment threadModules/_operator.c Outdated

bedevere-appBot added awaiting review and removed awaiting changes labels Feb 22, 2024

AlexWaygood requested a review from Eclips4 February 22, 2024 15:09

AlexWaygood reviewed Feb 22, 2024
View reviewed changes

sobolevn reviewed Feb 22, 2024
View reviewed changes

Comment threadModules/_operator.c Outdated
Comment threadModules/_operator.c Outdated
Comment threadLib/test/test_operator.py Outdated
Comment threadLib/operator.py Outdated

ThexXTURBOXx mentioned this pull request Feb 22, 2024
Refactor operators #115830
Closed

Eclips4 approved these changes Feb 22, 2024
View reviewed changes

bedevere-appBot added awaiting core review and removed awaiting review labels Feb 22, 2024

bateller approved these changes Feb 22, 2024
View reviewed changes

Fidget-Spinner reviewed Feb 22, 2024
View reviewed changes

Comment threadModules/_operator.c

pythongh-115808: Add is_none operator
72ccb45

ThexXTURBOXx added 4 commits March 4, 2024 15:07

Fix method declaration
dcfb77a

Cleanup test for is_none
8661aec

Add another test
90d6867

Rearrange everything to be in the same order
354acfb

ThexXTURBOXx force-pushed the issue-115808 branch from 434bc8b to 354acfbCompare March 4, 2024 14:07

Merge branch 'main' into issue-115808
5a4382f

Merge branch 'main' into issue-115808
cc9660a

Eclips4 reviewed Aug 6, 2024
View reviewed changes

Comment threadDoc/whatsnew/3.13.rst Outdated
Comment threadDoc/library/operator.rst Outdated

Apply suggestions
576a085

Add is_not_none operator
bdf17ff

Fix is_not_none operator
d8fed16

Eclips4 reviewed Aug 6, 2024
View reviewed changes

Comment threadModules/_operator.c Outdated

Eclips4 changed the title ~~gh-115808: Add is_none operator~~gh-115808: Add is_none and is_not_none operatorsAug 6, 2024

AA-Turner approved these changes Aug 7, 2024
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting core review labels Aug 7, 2024

Eclips4 approved these changes Aug 7, 2024
View reviewed changes

AA-Turner merged commit 5580f31 into python:mainAug 10, 2024

bedevere-appBot removed the awaiting merge label Aug 10, 2024

ZeroIntensity mentioned this pull request Aug 17, 2024
Add stubs for operator.is_none and operator.is_not_nonepython/typeshed#12535
Merged

blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
pythongh-115808: Addis_noneandis_not_nonetooperator(p…
34f25eb
…ython#115814) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>

Uh oh!

Uh oh!

Conversation

ThexXTURBOXx commented Feb 22, 2024• edited by AlexWaygood Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Feb 22, 2024• edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-appBot commented Feb 22, 2024

Uh oh!

Uh oh!

Eclips4 commented Feb 22, 2024

Uh oh!

ThexXTURBOXx commented Feb 22, 2024

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-appBot commented Feb 22, 2024

Uh oh!

ThexXTURBOXx commented Feb 22, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ThexXTURBOXx commented Feb 22, 2024

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

ThexXTURBOXx commented Feb 22, 2024

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Eclips4 left a comment

Choose a reason for hiding this comment

Uh oh!

bateller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ThexXTURBOXx commented Mar 4, 2024• edited by Eclips4 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ThexXTURBOXx commented May 17, 2024

Uh oh!

ThexXTURBOXx commented Aug 6, 2024

Uh oh!

Uh oh!

Uh oh!

ThexXTURBOXx commented Aug 6, 2024

Uh oh!

Eclips4 commented Aug 6, 2024

Uh oh!

ThexXTURBOXx commented Aug 6, 2024

Uh oh!

Uh oh!

AA-Turner commented Aug 7, 2024

Uh oh!

Eclips4 left a comment

Choose a reason for hiding this comment

Uh oh!

ThexXTURBOXx commented Aug 7, 2024

Uh oh!

AA-Turner commented Aug 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ThexXTURBOXx commented Feb 22, 2024•
edited by AlexWaygood
Loading

ghost commented Feb 22, 2024•
edited by ghost
Loading

ThexXTURBOXx commented Mar 4, 2024•
edited by Eclips4
Loading