Skip to content

gh-115778: Add a tierN annotation for instruction definition - #115815

Merged
gvanrossum merged 12 commits into
python:mainfrom
Eclips4:issue-115778
Feb 23, 2024
Merged

gh-115778: Add a tierN annotation for instruction definition#115815
gvanrossum merged 12 commits into
python:mainfrom
Eclips4:issue-115778

Conversation

@Eclips4

@Eclips4Eclips4 commented Feb 22, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Feb 22, 2024
Closed
markshannon
markshannon reviewed Feb 22, 2024
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement. Thanks.

Comment threadPython/bytecodes.c Outdated
Comment threadTools/cases_generator/lexer.py Outdated
gvanrossum
gvanrossum reviewed Feb 22, 2024
View reviewed changes

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LG, though I have two nits:

  • If there ever is a Tier 3, I expect that several of the tier checks will have to be adjusted -- currently there seems to be an assumption that if it's not T1 then it's T2 and vice versa.
  • Inferring tier 1 from specialized could be done differently.

Comment threadTools/cases_generator/tier2_abstract_generator.py Outdated
Comment threadTools/cases_generator/analyzer.py Outdated
@Eclips4Eclips4 mentioned this pull request Feb 23, 2024
Closed
AlexWaygood
AlexWaygood reviewed Feb 23, 2024
View reviewed changes
Comment threadTools/cases_generator/analyzer.py Outdated
Eclips4and others added 2 commits February 23, 2024 11:48
gvanrossum
gvanrossum approved these changes Feb 23, 2024
View reviewed changes

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gvanrossum
gvanrossum enabled auto-merge (squash) February 23, 2024 16:22
@Eclips4

Eclips4 commented Feb 23, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@gvanrossum
CI/CD failure is unrelated. I can reproduce it locally on my Windows x86_64 build with JIT. I'll create an issue
UPD: Ken has already created an issue: #115859

@gvanrossum
gvanrossum merged commit e4561e0 into python:mainFeb 23, 2024
@Eclips4
Eclips4 deleted the issue-115778 branch February 23, 2024 17:53
@gvanrossum

gvanrossum commented Feb 23, 2024

Copy link
Copy Markdown
Member

Thanks!

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@Eclips4@AlexWaygood@woodruffw
pythongh-115778: AddtierNannotation for instruction definitions (p…
6416271
…ython#115815)
This replaces the old `TIER_{ONE,TWO}_ONLY` macros. Note that `specialized` implies `tier1`.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@Eclips4@AlexWaygood@diegorusso
pythongh-115778: AddtierNannotation for instruction definitions (p…
805fb5a
…ython#115815)
This replaces the old `TIER_{ONE,TWO}_ONLY` macros. Note that `specialized` implies `tier1`.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@Eclips4@AlexWaygood@LukasWoodtli
pythongh-115778: AddtierNannotation for instruction definitions (p…
6bec67b
…ython#115815)
This replaces the old `TIER_{ONE,TWO}_ONLY` macros. Note that `specialized` implies `tier1`.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood left review comments
@gvanrossumgvanrossumgvanrossum approved these changes
@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Eclips4@gvanrossum@markshannon@AlexWaygood