Uh oh!
There was an error while loading. Please reload this page.
gh-96471: Correct docs for queue shutdown raises - #115838
Conversation
4fdeb68 to
63bdd42Compare63bdd42 to
c1bcb5dCompare
gvanrossum
left a comment
There was a problem hiding this comment.
Thanks! Two nits and then I'll merge this. (I feel bad that I didn't catch this in review.)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
gvanrossum
left a comment
There was a problem hiding this comment.
Please fix the nits I called out.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
EpicWink
commented
Feb 25, 2024
I have made the requested changes; please review again |
Uh oh!
There was an error while loading. Please reload this page.
Queue.join()andQueue.task_done()documentation (including doc-string)Queue.shutdown()behaviour (it doesn't raise itself, but causes other methods to raise)Queue.task_done()is called byQueue.shutdown(immediate=True)for each item in the queueCaused by: #104750
📚 Documentation preview 📚: https://cpython-previews--115838.org.readthedocs.build/