Skip to content

gh-112087: Make list_{subscript, ass_slice, slice} to be thread-safe - #115854

Closed
corona10 wants to merge 2 commits into
python:mainfrom
corona10:gh-112087-part5
Closed

gh-112087: Make list_{subscript, ass_slice, slice} to be thread-safe#115854
corona10 wants to merge 2 commits into
python:mainfrom
corona10:gh-112087-part5

Conversation

@corona10

@corona10corona10 commented Feb 23, 2024

Copy link
Copy Markdown
Member

@corona10

Copy link
Copy Markdown
MemberAuthor

To port list_ass_slice_impl from nogil implementation, we may need to port also other implementations but it occurs crash in my local so I need more investigation.
https://github.com/colesbury/nogil-3.12/blob/cedde4f5ec3759ad723c89d44738776f362df564/Objects/listobject.c#L101-L136

So before porting all of them, I propose a simpler implementation but not sure that it will be safe or acceptable performance. :)

@corona10
corona10 marked this pull request as draft February 24, 2024 00:12
@corona10

Copy link
Copy Markdown
MemberAuthor

Hmm let me check more

@corona10

Copy link
Copy Markdown
MemberAuthor

I will continue to work on this PR after #115875 is merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@corona10